X86 platform drivers
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Kurt Borja <kuurtb@gmail.com>
Cc: Mark Pearson <mpearson-lenovo@squebb.ca>,
	 Hans de Goede <hdegoede@redhat.com>,
	platform-driver-x86@vger.kernel.org,
	 LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] platform/x86: think-lmi: Fix resource cleanup flaws
Date: Mon, 30 Jun 2025 11:54:55 +0300 (EEST)	[thread overview]
Message-ID: <5ee91db8-8ed1-6860-7736-9fb723371bc1@linux.intel.com> (raw)
In-Reply-To: <20250628-lmi-fix-v2-0-c530e1c959d7@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1340 bytes --]

On Sat, 28 Jun 2025, Kurt Borja wrote:

> Hi all,
> 
> First patch is a prerequisite in order to avoid NULL pointer
> dereferences in error paths. Then two fixes follow.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Please send v3 with stable Cc tags in all these so that this dependency 
gets automatically handled (as per documentation).

I'll apply this through the fixes branch but I can deal with the removal 
of the lenovo/ folder from the file names myself while applying.

> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
> ---
> Changes in v2:
> 
> [PATCH 02]
>   - Remove kobject_del() and commit message remark. It turns out it's
>     optional to call this (my bad)
>   - Leave only one fixes tag. The other two are not necessary.
> 
> - Link to v1: https://lore.kernel.org/r/20250628-lmi-fix-v1-0-c6eec9aa3ca7@gmail.com
> 
> ---
> Kurt Borja (3):
>       platform/x86: think-lmi: Create ksets consecutively
>       platform/x86: think-lmi: Fix kobject cleanup
>       platform/x86: think-lmi: Fix sysfs group cleanup
> 
>  drivers/platform/x86/lenovo/think-lmi.c | 90 +++++++++++----------------------
>  1 file changed, 30 insertions(+), 60 deletions(-)
> ---
> base-commit: 73f0f2b52c5ea67b3140b23f58d8079d158839c8
> change-id: 20250628-lmi-fix-98143b10d9fd
> 

-- 
 i.

  parent reply	other threads:[~2025-06-30  8:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-29  2:32 [PATCH v2 0/3] platform/x86: think-lmi: Fix resource cleanup flaws Kurt Borja
2025-06-29  2:32 ` [PATCH v2 1/3] platform/x86: think-lmi: Create ksets consecutively Kurt Borja
2025-06-29  2:32 ` [PATCH v2 2/3] platform/x86: think-lmi: Fix kobject cleanup Kurt Borja
2025-06-29  2:32 ` [PATCH v2 3/3] platform/x86: think-lmi: Fix sysfs group cleanup Kurt Borja
2025-06-30  8:54 ` Ilpo Järvinen [this message]
2025-06-30 17:19   ` [PATCH v2 0/3] platform/x86: think-lmi: Fix resource cleanup flaws Kurt Borja

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ee91db8-8ed1-6860-7736-9fb723371bc1@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=hdegoede@redhat.com \
    --cc=kuurtb@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox