From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73192C63697 for ; Thu, 26 Nov 2020 10:36:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DC2020BED for ; Thu, 26 Nov 2020 10:36:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="RLbvx+GR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726099AbgKZKgb (ORCPT ); Thu, 26 Nov 2020 05:36:31 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48309 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730463AbgKZKga (ORCPT ); Thu, 26 Nov 2020 05:36:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606386988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TPDoUGqQUZE3uOuQTeXyhdS26UrKjbT7KQQwgL6gki0=; b=RLbvx+GRGL2N9g23EDJM5ypXCUK38qq7VK6zqqYMKVOUg9nzja/MCqyC3axcGWAY80FSFF q+R6Pu3ul9BSKUun9FTm0iXBU2wSX4/3JENSKJAsChWriiinZx/GaBzVg04+WHe5XPj1jk tt0fJ5rALVwlSQvcTRsPHkyYvYbHhBE= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-359-aJ17cFUEMRmJMvynEqCn2w-1; Thu, 26 Nov 2020 05:36:26 -0500 X-MC-Unique: aJ17cFUEMRmJMvynEqCn2w-1 Received: by mail-ej1-f69.google.com with SMTP id a13so655853ejv.17 for ; Thu, 26 Nov 2020 02:36:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TPDoUGqQUZE3uOuQTeXyhdS26UrKjbT7KQQwgL6gki0=; b=tesAM9EQerN0DtAJzNx+4WGdvx3T9M5p+OB0Lzuo9Mf4vIQLQlg/fWkMEHBXKp9+JF 72hztkBDPhNEiu240tHPoqikd8qSd0UJX3jCngvYpVFdeDQTm+0BCZTCaazBnWBKCJOm Hso3TUqLShge2apByHjbucAGrbRwQfFZu4P1rMHizQqyzJqGuU3EMlbOnMCBMxqprx5V TNi88l9yluEXuw+2kE3vo17SjsvrylxRk3FlbZ8JAvEfKf4tFCQ5Jmw2f3s6BPkDU3zA 4ufQE6BsmlTDzhmzB++IZhaDAyXQe2zSO7pdmRTiHNRRMPF1SoG+0lfVexGPXMBGnvzg wrPQ== X-Gm-Message-State: AOAM533VYYQJD+sRRdOyYHkT8lWi2RNCrgN3HVgU4XgExgEKfU3E5V+V hqGbHrSzgcqXyIqSKrryXuRWpZpsm34IoO5KUNObNMg7PL2W5T7l2XO50O4K7MYDUuHbKgmb2jK R9TrAqKJrL42zUWWOBDZZZIiXCqzzuOl66w== X-Received: by 2002:a17:906:5a8b:: with SMTP id l11mr1897273ejq.99.1606386985771; Thu, 26 Nov 2020 02:36:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJzbUOXuvfqs9aQrq6zgmCyzmAWsCx6BeBujPO7apZ2SMqzWEGeNdoESK3QIgFrbzXNgzFElVw== X-Received: by 2002:a17:906:5a8b:: with SMTP id l11mr1897253ejq.99.1606386985575; Thu, 26 Nov 2020 02:36:25 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id i9sm2752224ejf.41.2020.11.26.02.36.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Nov 2020 02:36:24 -0800 (PST) Subject: Re: [External] Re: [PATCH v3] ACPI: platform-profile: Add platform profile support To: Bastien Nocera , Mark Pearson , =?UTF-8?Q?Barnab=c3=a1s_P=c5=91cze?= Cc: "rjw@rjwysocki.net" , "mgross@linux.intel.com" , "linux-acpi@vger.kernel.org" , "mario.limonciello@dell.com" , "eliadevito@gmail.com" , "bberg@redhat.com" , "platform-driver-x86@vger.kernel.org" , "dvhart@infradead.org" References: <20201115004402.342838-1-markpearson@lenovo.com> <761671b3-ad26-230b-e709-05ce3bd69498@redhat.com> <27a41e3d678f9d7fc889a3a77df87f9ed408887d.camel@hadess.net> <92a564fa-686f-455d-a0cb-962d4d87a8c7@redhat.com> <4e82d54f-33c2-e880-c5f8-beb9d3460cdb@lenovo.com> <2207fea9195877a7ac6d6d203d9f81d07362a80f.camel@hadess.net> From: Hans de Goede Message-ID: <64447d3f-c328-aef2-cd29-a9eed10ff27e@redhat.com> Date: Thu, 26 Nov 2020 11:36:23 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <2207fea9195877a7ac6d6d203d9f81d07362a80f.camel@hadess.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, On 11/25/20 11:32 PM, Bastien Nocera wrote: > On Wed, 2020-11-25 at 14:41 -0500, Mark Pearson wrote: >> On 25/11/2020 11:42, Hans de Goede wrote: >>> Hi, >>> >>> On 11/24/20 4:30 PM, Bastien Nocera wrote: >>>> On Sat, 2020-11-21 at 15:27 +0100, Hans de Goede wrote: >>>>> Hi, >>>>> On 11/20/20 8:50 PM, Barnabás Pőcze wrote: >>>>>> Hi >>>>>> 2020. november 15., vasárnap 1:44 keltezéssel, Mark Pearson >>>>>> írta: >>>>>> >>>>> Bastien, what do you think about Barnabás' suggestion to always >>>>> have the files present and use poll (POLL_PRI) on it to see >>>>> when >>>>> it changes, listing maybe "none" as available profiles when >>>>> there >>>>> is no provider? >>>> >>>> Whether the file exists or doesn't, we have ways to monitor it >>>> appearing or disappearing. I can monitor the directory with >>>> inotify >>>> to see the file appearing or disappearing, or I can monitor the >>>> file with inotify to see whether it changes. >>> >>> Ok, do you have a preference either way? I personally think having >>> the file only appear if its functional is a bit cleaner. So if it >>> does not matter much for userspace either way then I suggest we go >>> that route. >>> >> My (limited) vote is having the file appear when the profile is >> loaded >> seems nicer (and to disappear if the profile is unloaded). No >> profile, >> no interface just seems elegant. >> >> I pretty much have v4 of the patches ready to go (I wanted to rebase >> on >> the update for the palm sensor and finished that today). I'm happy to >> hold off on them until we're ready if that helps. Bastien - let me >> know >> if it would be useful to have a version to test against to see what >> will >> work best for you, or if you need something different. Definitely >> want >> to make sure user space gets the best option as my understanding is >> changing this later becomes a pain :) > > I don't have the hardware. I agree with you that "no profile = no file" > seems cleaner, but whichever is easier for you. Ok, lets go with that then (so same as in v3). Mark, if you can submit v4 upstream that would be great. Regards, Hans