Re: [PATCH v2] platform/x86/amd/hsmp: Add CONFIG_ACPI dependency

["Hegde, Suma" <Suma.Hegde@amd.com>]

Hi Hans,

On 2/19/2024 6:15 PM, Hans de Goede wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> Hi,
>
> On 1/30/24 08:34, Suma Hegde wrote:
>> HSMP interface is only supported on x86 based AMD EPYC line of
>> processors. Driver uses ACPI APIs, so make it dependent on CONFIG_ACPI.
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Closes: https://lore.kernel.org/oe-kbuild-all/202401281437.aus91srb-lkp@intel.com/
>> Signed-off-by: Suma Hegde <suma.hegde@amd.com>
>> Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
> Thank you for your patch, I've applied this patch to my review-hans
> branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>
> Note it will show up in my review-hans branch once I've pushed my
> local branch there, which might take a while.
>
> I will include this patch in my next fixes pull-req to Linus
> for the current kernel development cycle.
>
> Regards,
>
> Hans

This change was merged by Ilpo in review-ilpo branch into commit: 
platform/x86/amd/hsmp: Add support for ACPI based probing.

>
>
>> ---
>> Changes since v1:
>> Correct the email id for Naveen Krishna Chatradhi and change it as
>> Reviewed-by.
>>
>>   drivers/platform/x86/amd/Kconfig | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/platform/x86/amd/Kconfig b/drivers/platform/x86/amd/Kconfig
>> index 54753213cc61..f88682d36447 100644
>> --- a/drivers/platform/x86/amd/Kconfig
>> +++ b/drivers/platform/x86/amd/Kconfig
>> @@ -8,7 +8,7 @@ source "drivers/platform/x86/amd/pmc/Kconfig"
>>
>>   config AMD_HSMP
>>        tristate "AMD HSMP Driver"
>> -     depends on AMD_NB && X86_64
>> +     depends on AMD_NB && X86_64 && ACPI
>>        help
>>          The driver provides a way for user space tools to monitor and manage
>>          system management functionality on EPYC server CPUs from AMD.