From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maximilian Luz Subject: Re: [PATCH 5.4 regression fix] Input: soc_button_array - partial revert of support for newer surface devices Date: Sat, 5 Oct 2019 17:01:18 +0200 Message-ID: <65b265d2-f7a8-bcd7-e63f-f8efb7349324@gmail.com> References: <20191005105551.353273-1-hdegoede@redhat.com> <222c364a-bc2b-5960-3fe4-7d1ce222e3e2@gmail.com> <96cea5be-d285-8323-1ab2-9c8e87993165@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <96cea5be-d285-8323-1ab2-9c8e87993165@redhat.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Hans de Goede , Dmitry Torokhov , Andy Shevchenko Cc: linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org Hi, again On 10/5/19 3:20 PM, Hans de Goede wrote: > Ok, on x86 the GPIO drivers really should all be builtin because > various ACPI methods including device D0 / D3 (power-on/off) methods > may depend on them. So normally this should never happen. > > If this (-EPROBE_DEFER on surface devices) somehow still is happening > please let me know and we will figure something out. I have never personally experienced this, only received reports which indicated this and that the change (as well as manually reloading soc_button_array) fixed it. I will come back to you if I hear anything in regards to this again. I have now also tested your patch on the Surface Book 2. Does not cause any issues as far as I can tell. Tested-by: Maximilian Luz And if that is needed/wanted Acked-by: Maximilian Luz Regards, Maximilian