From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: "Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Ingo Molnar" <mingo@kernel.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] platform/x86/intel: power-domains: Fix error code in tpmi_init()
Date: Fri, 06 Jun 2025 07:28:26 -0700 [thread overview]
Message-ID: <67fea61ec40d0e54d4674ab83728e84120d9fb9d.camel@linux.intel.com> (raw)
In-Reply-To: <aEKvIGCt6d8Gcx4S@stanley.mountain>
On Fri, 2025-06-06 at 12:04 +0300, Dan Carpenter wrote:
> Return -ENOMEM instead of success if kcalloc() fails.
>
> Fixes: e37be5d85c60 ("platform/x86/intel: power-domains: Add
> interface to get Linux die ID")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Acked-by:Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/platform/x86/intel/tpmi_power_domains.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/tpmi_power_domains.c
> b/drivers/platform/x86/intel/tpmi_power_domains.c
> index 0c5c88eb7baf..9d8247bb9cfa 100644
> --- a/drivers/platform/x86/intel/tpmi_power_domains.c
> +++ b/drivers/platform/x86/intel/tpmi_power_domains.c
> @@ -228,8 +228,10 @@ static int __init tpmi_init(void)
>
> domain_die_map = kcalloc(size_mul(topology_max_packages(),
> MAX_POWER_DOMAINS),
> sizeof(*domain_die_map),
> GFP_KERNEL);
> - if (!domain_die_map)
> + if (!domain_die_map) {
> + ret = -ENOMEM;
> goto free_domain_mask;
> + }
>
> ret = cpuhp_setup_state(CPUHP_AP_ONLINE_DYN,
> "platform/x86/tpmi_power_domains:onl
> ine",
next prev parent reply other threads:[~2025-06-06 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-06 9:04 [PATCH] platform/x86/intel: power-domains: Fix error code in tpmi_init() Dan Carpenter
2025-06-06 14:28 ` srinivas pandruvada [this message]
2025-06-09 7:52 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67fea61ec40d0e54d4674ab83728e84120d9fb9d.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox