From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Cc: "Jorge Lopez" <jorge.lopez2@hp.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Mark Gross" <markgross@kernel.org>,
"Thomas Weißschuh" <linux@weissschuh.net>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, dan.carpenter@linaro.org,
kernel-janitors@vger.kernel.org, error27@gmail.com,
vegard.nossum@oracle.com, darren.kenny@oracle.com
Subject: Re: [PATCH v3 2/4] platform/x86: hp-bioscfg: move mutex_lock() down in hp_add_other_attributes()
Date: Mon, 13 Nov 2023 21:11:03 +0200 (EET) [thread overview]
Message-ID: <682889a3-2f6e-5141-1f5d-1150119ad1fb@linux.intel.com> (raw)
In-Reply-To: <20231113185852.3579970-2-harshit.m.mogalapalli@oracle.com>
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
On Mon, 13 Nov 2023, Harshit Mogalapalli wrote:
> attr_name_kobj's memory allocation is done with mutex_lock() held, this
> is not needed.
>
> Move allocation outside of mutex_lock() so unlock is not needed when
> allocation fails.
>
> Suggested-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
next prev parent reply other threads:[~2023-11-13 19:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 18:58 [PATCH v3 1/4] platform/x86: hp-bioscfg: Simplify return check in hp_add_other_attributes() Harshit Mogalapalli
2023-11-13 18:58 ` [PATCH v3 2/4] platform/x86: hp-bioscfg: move mutex_lock() down " Harshit Mogalapalli
2023-11-13 19:11 ` Ilpo Järvinen [this message]
2023-11-13 18:58 ` [PATCH v3 3/4] platform/x86: hp-bioscfg: Fix error handling " Harshit Mogalapalli
2023-11-13 19:08 ` Ilpo Järvinen
2023-11-13 18:58 ` [PATCH v3 4/4] platform/x86: hp-bioscfg: Remove unused obj " Harshit Mogalapalli
2023-11-13 19:10 ` [PATCH v3 1/4] platform/x86: hp-bioscfg: Simplify return check " Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=682889a3-2f6e-5141-1f5d-1150119ad1fb@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=dan.carpenter@linaro.org \
--cc=darren.kenny@oracle.com \
--cc=error27@gmail.com \
--cc=harshit.m.mogalapalli@oracle.com \
--cc=hdegoede@redhat.com \
--cc=jorge.lopez2@hp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@weissschuh.net \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox