From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Alexis Belmonte <alexbelm48@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
platform-driver-x86@vger.kernel.org, putr4.s@gmail.com
Subject: Re: [PATCH 1/2] platform/x86: hp-wmi: Tidy up module source code
Date: Wed, 24 Jan 2024 12:28:41 +0200 (EET) [thread overview]
Message-ID: <6c27cef8-d301-0634-10d4-9fac097e6e97@linux.intel.com> (raw)
In-Reply-To: <ZZchYfQcg0fPBJZy@alexis-pc>
On Thu, 4 Jan 2024, Alexis Belmonte wrote:
> This commit performs four things:
>
> - fix up the GUID string inconsistency (lower case 'e') from the
> WMI module alias declaration/macro definition
>
> - separate GUID macros from the embedded controller offset macros
>
> - rename the description of the module to better represent what it
> actually achieves as a whole
>
> - add a space right before the '*' pointer qualifier to match the
> other array declarations
>
> This also prepares the terrain for integrating support work for boards
> identified as '8BAD', which corresponds to HP's Omen 17 ck2xxx models.
>
> Signed-off-by: Alexis Belmonte <alexbelm48@gmail.com>
Hi,
Thanks for updating but could you please resubmit these properly with v2
in the subject so that it is easier to locate if somebody has to look it
up from the archives many years from now.
--
i.
next prev parent reply other threads:[~2024-01-24 10:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-04 21:21 [PATCH 1/2] platform/x86: hp-wmi: Tidy up module source code Alexis Belmonte
2024-01-24 10:28 ` Ilpo Järvinen [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-12-31 10:46 Alexis Belmonte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c27cef8-d301-0634-10d4-9fac097e6e97@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=alexbelm48@gmail.com \
--cc=hdegoede@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=putr4.s@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox