X86 platform drivers
 help / color / mirror / Atom feed
From: Armin Wolf <W_Armin@gmx.de>
To: Fa-Iz Faadhillah Ibrahim <faiz.faadhillah@gmail.com>,
	jlee@suse.com, basak.sb2006@gmail.com, rayanmargham4@gmail.com
Cc: kuurtb@gmail.com, ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/4] platform/x86: acer-wmi: Add fan control support
Date: Thu, 2 Oct 2025 21:26:59 +0200	[thread overview]
Message-ID: <6fddd622-e270-4cd7-8c36-c656e703178b@gmx.de> (raw)
In-Reply-To: <6218970.lOV4Wx5bFT@cacher>

Am 29.09.25 um 04:04 schrieb Fa-Iz Faadhillah Ibrahim:

> On Wednesday, September 24, 2025 4:52 AM Armin Wolf wrote:
>> This patch series aims to add fan control support to the acer-wmi
>> driver. The patches are compile-tested only and need to be tested
>> on real hardware to verify that they actually work.
>>
>> I CCed three users who requested support for this feature. I would be
>> very happy if one of you could test those patches and report back.
>>
>> Changes since v1:
>> - remove unnecessary blank line
>>
>> Changes since RFC v2:
>> - improve error handling when setting fan behavior
>> - Add Reviewed-by tags
>> - whitelist PHN16-72
>>
>> Changes since RFC v1:
>> - remove duplicate include and replace hwmon_pwm_mode with
>>    hwmon_pwm_enable in second patch
>>
>> Armin Wolf (4):
>>    platform/x86: acer-wmi: Fix setting of fan behavior
>>    platform/x86: acer-wmi: Add fan control support
>>    platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51
>>    platform/x86: acer-wmi: Add support for PHN16-72
>>
>>   drivers/platform/x86/acer-wmi.c | 308 +++++++++++++++++++++++++++++---
>>   1 file changed, 283 insertions(+), 25 deletions(-)
> Hi,
>
> I've tested your patch on my PHN16-72, Fan control works just fine, and it does
> detect my laptop properly.
>
> Thanks,
> Fa-Iz Faadhillah Ibrahim
>
Thank you, i will send a improved patch series in the coming days. I would be
very happy if you cloud test those too.

Thanks,
Armin Wolf


      reply	other threads:[~2025-10-02 19:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-23 21:52 [PATCH v2 0/4] platform/x86: acer-wmi: Add fan control support Armin Wolf
2025-09-23 21:52 ` [PATCH v2 1/4] platform/x86: acer-wmi: Fix setting of fan behavior Armin Wolf
2025-09-24 11:00   ` Ilpo Järvinen
2025-10-02 19:16     ` Armin Wolf
2025-09-23 21:52 ` [PATCH v2 2/4] platform/x86: acer-wmi: Add fan control support Armin Wolf
2025-09-24 10:52   ` Ilpo Järvinen
2025-10-02 19:23     ` Armin Wolf
2025-10-06  8:11       ` Ilpo Järvinen
2025-09-23 21:52 ` [PATCH v2 3/4] platform/x86: acer-wmi: Enable fan control for PH16-72 and PT14-51 Armin Wolf
2025-09-23 21:52 ` [PATCH v2 4/4] platform/x86: acer-wmi: Add support for PHN16-72 Armin Wolf
2025-09-29  2:04 ` [PATCH v2 0/4] platform/x86: acer-wmi: Add fan control support Fa-Iz Faadhillah Ibrahim
2025-10-02 19:26   ` Armin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6fddd622-e270-4cd7-8c36-c656e703178b@gmx.de \
    --to=w_armin@gmx.de \
    --cc=basak.sb2006@gmail.com \
    --cc=faiz.faadhillah@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jlee@suse.com \
    --cc=kuurtb@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rayanmargham4@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox