From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gustavo A. R. Silva" Subject: Re: [PATCH] platform/x86: acer-wmi: refactor function has_cap Date: Mon, 6 Aug 2018 15:31:13 -0500 Message-ID: <74e18643-5d0a-ecad-b3c3-4b27f399d8ce@embeddedor.com> References: <20180806200052.GA29026@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-GB Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: "Lee, Chun-Yi" , Darren Hart , Andy Shevchenko , Joe Perches , David Laight , Platform Driver , Linux Kernel Mailing List List-Id: platform-driver-x86.vger.kernel.org On 8/6/18 3:16 PM, Andy Shevchenko wrote: > On Mon, Aug 6, 2018 at 11:00 PM, Gustavo A. R. Silva > wrote: >> Refactor function has_cap in order to avoid returning integer >> values, when instead it should return booleans. >> >> This code was detected with the help of Coccinelle. >> >> Signed-off-by: Gustavo A. R. Silva >> --- >> drivers/platform/x86/acer-wmi.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c >> index 8952173..ff1689d 100644 >> --- a/drivers/platform/x86/acer-wmi.c >> +++ b/drivers/platform/x86/acer-wmi.c >> @@ -672,10 +672,7 @@ static void __init find_quirks(void) >> >> static bool has_cap(u32 cap) >> { >> - if ((interface->capability & cap) != 0) >> - return 1; >> - >> - return 0; >> + return (interface->capability & cap) != 0; >> } > > Thanks, as Joe mentioned even != 0 part is not needed (followed by > unneeded parens), though I would let it be (one line is good enough to > me) if there will be no strong preferences. > Oh, yeah. I like it better what Joe suggested. Let me send v2, shortly. Thanks -- Gustavo