Re: [PATCH] platform/x86: x86-android-tablets: fix gpio_secondary_fwnode_init() not working

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

On Tue, 1 Sep 2026, Andy Shevchenko wrote:

> On Mon, Aug 31, 2026 at 10:11:57PM +0200, Hans de Goede wrote:
> > acpi_bus_find_device_by_name() call returns a pointer to the device object
> > on the ACPI bus, aka the ACPI companion device.
> > 
> > gpio_secondary_fwnode_init() then continues with setting the secondary
> > fwnode on this device. But this is not the actual physical device for
> > the GPIO controller (e.g. the GPIO controller platform bus device).
> > 
> > This mismatch is causing GPIO lookups by secondary fwnode to not work.
> > 
> > Modify gpio_secondary_fwnode_init() to instead set the secondary fwnode
> > of the first physical device associated with the ACPI companion device.
> > 
> > This fixes the GPIO lookups not working.
> 
> ...
> 
> > static int gpio_secondary_fwnode_init(struct device *parent,
> 
> >  		if (WARN_ON(!fwnode))
> >  			return -ENOENT;
> >  
> > -		set_secondary_fwnode(dev, fwnode);
> > +		struct device *phys_dev = acpi_get_first_physical_node(to_acpi_device(dev));
> 
> It doesn't look like an auto cleaning pointer, so let's make a declaration
> outside of the code?
> 
> > +		if (!phys_dev)
> > +			return dev_err_probe(parent,
> > +					     -ENODEV, "No physical device for ACPI GPIO dev: %s\n",
> > +					     (*swnode)->name);
> 
> Hmm... Why not %pfwP?

Hi Hans,

I'm waiting for v2.

-- 
 i.