Re: [PATCH v2 1/2] platform/x86/amd/pmc: Fix SMU command submission path on new AMD platform

[Shyam Sundar S K <Shyam-sundar.S-k@amd.com>]

On 8/23/2024 19:49, Ilpo Järvinen wrote:
> On Thu, 22 Aug 2024, Shyam Sundar S K wrote:
> 
>> The commit 426463d94d45 ("platform/x86/amd/pmc: Send OS_HINT command for
>> new AMD platform") was introduced to enable sending mailbox commands to
>> PMFW on newer platforms. However, it was later discovered that the commit
>> did not configure the correct message port ID (i.e., S2D or PMC). Without
>> this configuration, all command submissions to PMFW are treated as
>> invalid, leading to command failures.
>>
>> To address this issue, the CPU ID association for the new platform needs
>> to be added in amd_pmc_get_ip_info(). This ensures that the correct SMU
>> port IDs are selected.
>>
>> Fixes: 426463d94d45 ("platform/x86/amd/pmc: Send OS_HINT command for new AMD platform")
>> Co-developed-by: Sanket Goswami <Sanket.Goswami@amd.com>
>> Signed-off-by: Sanket Goswami <Sanket.Goswami@amd.com>
>> Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
>> ---
> 
> Hi,
> 
> I've applied both of these patches to review-ilpo now. The above doesn't 
> inspire much confidence though as that sounded like nothing worked with 
> 426463d94d45 so it probably wasn't tested at all before sending. :-(
> 

Hi Ilpo,

I apologize for the oversight. The SMU message ID was hardcoded in my
bring-up environment during testing, which is why I didn't consider
adding the CPU ID check in amd_pmc_get_ip_info().

But surely will take of this in future.

Thanks,
Shyam