From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E34D1714A8 for ; Sun, 6 Oct 2024 10:38:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728211088; cv=none; b=oFe3a1+K4d0my4WADWt1UMRCL+xUuQ0ol0p9Zimkg1FTT/NhHJ7H/Z+tQkyMMzBnFOLvQPihsGdJeRuhWRbdXlqhdlOI4KuNDC7R+B9ZtmSrlMXSvzBt7WIv1akbSB7thNvj2nLK1A9m5+1D69URd0E1CgOx3HfKvWHRsVua0gw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728211088; c=relaxed/simple; bh=Bq7Tz41q+fa0j+3ZQeIlm1+u4L9RWU0OmleWy7EWtKY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cXRn3Ps6oq+JAc5LjCv8zmczD9BHoDFlB3amqgtsSYTH87yRPKz+Mp1oZU8zezBjuT/BdVLlGIUPMK2AOT9qljkV40nlsGvdOQERuX47V9Auib/m864qDVE4Dp218adNYlKZpnNXBjO5Paxeeq+SX+7yH6i3mnvUaRgyOjy9TBY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Pg3Zmx7E; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Pg3Zmx7E" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728211085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1ItPi/oOw2IPhVtK1a1NEvIYqd7WVKNv5sJgtuuovmM=; b=Pg3Zmx7E6ivGHNO4qEBNzMfmnQIBvDRdErfBHDXCE2FKNJ0JokRLk6Bo4wLmIzmiBCLy2c v05oEV2kGVJdZiYMzB/hBorlBzV04jm5UrIr/QrL7GpG8ET9dizvhzLcn6nmw2q+bGkVIY gkAVHe0QPrSwspk5K1MGcQ6LB2akBek= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-AHu_xSgEMBaTguR9MKN9OA-1; Sun, 06 Oct 2024 06:38:03 -0400 X-MC-Unique: AHu_xSgEMBaTguR9MKN9OA-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a7d2d414949so324091966b.0 for ; Sun, 06 Oct 2024 03:38:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728211083; x=1728815883; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1ItPi/oOw2IPhVtK1a1NEvIYqd7WVKNv5sJgtuuovmM=; b=ZNx44sAq3JeQyKHHEuvUUzCVBEEw2P3oUVllm85+1ivDEtR9BM/78ucFEv3lT3gL2A nvyoG/ZKJetBdtj9VRJOlISSxkFgZCQZpg4nI+aHhkd12pVYJHrwMQk6Qzy+fGefku6f k+chJNWiuGQj6M7CVYSNXry0v9BkecsmtnAEhD+i8drpNauv+chca9wxb3wNV5TVvTTR QgP7HYer4e0DOu5rMMkw5LJyr4EErLeYWcCVxVW6+U9m/A4axPvex1ooH3NgG0/UIEwl o/hbBCIFOG/ZnOWVngDSD6y/GNugBZiTHq5wqavSfu/rxFzLdAaby4Dp96WCevfh8URu V7Yg== X-Forwarded-Encrypted: i=1; AJvYcCVCEjAg+9YamtrayWXA8KNyUqRiXNgD8aoRVMY6tEIUIV4kT6X9HuJ05sq+iubdJbFZGp8+uoCI2IJnNzYK3pGj+mBo@vger.kernel.org X-Gm-Message-State: AOJu0YwMAecD28c2f0oxifMis1+iYLuXq6gKkdS4q+mPCr53hZ39MRm/ hUiAVFn8VRFnwHRk7WwUahEigKWDcoz0p6PkKQQ2nHTU9KQWvOvZVCZPuhTZTvOkw1QHYDjeJZX /7Ic0Cw0IhIagK/VYeCnoOFgwv2itjtrZ1vIt3ekXT/frPeQEKlirlxmOoOYshE29YVtNUDU= X-Received: by 2002:a17:907:980a:b0:a99:4152:1cb4 with SMTP id a640c23a62f3a-a99415220a5mr372218566b.42.1728211082684; Sun, 06 Oct 2024 03:38:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEMr8aLIFGNj6c7j0ibRW7YvJlcGsorT3VikyA0OZXv+aCTbD1uwOyPVfMak4HF5NdQnAho6g== X-Received: by 2002:a17:907:980a:b0:a99:4152:1cb4 with SMTP id a640c23a62f3a-a99415220a5mr372216966b.42.1728211082275; Sun, 06 Oct 2024 03:38:02 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9944839974sm125210766b.218.2024.10.06.03.38.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Oct 2024 03:38:01 -0700 (PDT) Message-ID: <7deea96e-61bd-4bb1-b478-d908ff735d70@redhat.com> Date: Sun, 6 Oct 2024 12:38:00 +0200 Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] platform/x86:intel/pmc: Disable ACPI PM Timer disabling on Sky and Kabe Lake To: Rajneesh Bhardwaj , David E Box , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Andy Shevchenko Cc: Paul Menzel , Todd Brandt , Marek Maslanka , Daniel Lezcano , regressions@lists.linux.dev, linux-pm@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20241003202614.17181-1-hdegoede@redhat.com> <20241003202614.17181-2-hdegoede@redhat.com> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20241003202614.17181-2-hdegoede@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, On 3-Oct-24 10:26 PM, Hans de Goede wrote: > There have been multiple reports that the ACPI PM Timer disabling is > causing Sky and Kabe Lake systems to hang on all suspend (s2idle, s3, > hibernate) methods. > > Remove the acpi_pm_tmr_ctl_offset and acpi_pm_tmr_disable_bit settings from > spt_reg_map to disable the ACPI PM Timer disabling on Sky and Kabe Lake to > fix the hang on suspend. > > Fixes: e86c8186d03a ("platform/x86:intel/pmc: Enable the ACPI PM Timer to be turned off when suspended") > Reported-by: Paul Menzel > Closes: https://lore.kernel.org/linux-pm/18784f62-91ff-4d88-9621-6c88eb0af2b5@molgen.mpg.de/ > Reported-by: Todd Brandt > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219346 > Cc: Marek Maslanka > Signed-off-by: Hans de Goede I've now applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans > --- > drivers/platform/x86/intel/pmc/spt.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/platform/x86/intel/pmc/spt.c b/drivers/platform/x86/intel/pmc/spt.c > index 2cd2b3c68e46..ab993a69e33e 100644 > --- a/drivers/platform/x86/intel/pmc/spt.c > +++ b/drivers/platform/x86/intel/pmc/spt.c > @@ -130,8 +130,6 @@ const struct pmc_reg_map spt_reg_map = { > .ppfear_buckets = SPT_PPFEAR_NUM_ENTRIES, > .pm_cfg_offset = SPT_PMC_PM_CFG_OFFSET, > .pm_read_disable_bit = SPT_PMC_READ_DISABLE_BIT, > - .acpi_pm_tmr_ctl_offset = SPT_PMC_ACPI_PM_TMR_CTL_OFFSET, > - .acpi_pm_tmr_disable_bit = SPT_PMC_BIT_ACPI_PM_TMR_DISABLE, > .ltr_ignore_max = SPT_NUM_IP_IGN_ALLOWED, > .pm_vric1_offset = SPT_PMC_VRIC1_OFFSET, > };