X86 platform drivers
 help / color / mirror / Atom feed
From: "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>
To: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	"Kammela, Gayatri" <gayatri.kammela@intel.com>
Cc: "dvhart@infradead.org" <dvhart@infradead.org>,
	"alex.hung@canonical.com" <alex.hung@canonical.com>,
	"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
	"amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>,
	"lenb@kernel.org" <lenb@kernel.org>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"Zhang, Rui" <rui.zhang@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"andriy.shevchenko@linux.intel.com"
	<andriy.shevchenko@linux.intel.com>,
	"Westerberg, Mika" <mika.westerberg@intel.com>,
	"Prestopine, Charles D" <charles.d.prestopine@intel.com>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
Subject: Re: [PATCH v1 1/3] ACPI: fix: Update Tiger Lake ACPI device IDs
Date: Fri, 27 Mar 2020 20:37:11 +0000	[thread overview]
Message-ID: <7e9c5faa9c4c873b6f5b5a8a526134cd92ef6a2a.camel@intel.com> (raw)
In-Reply-To: <f2b887a74103500ab59c42e6082f9c52f2063e4a.1585335927.git.gayatri.kammela@intel.com>

On Fri, 2020-03-27 at 13:24 -0700, Gayatri Kammela wrote:
> Tiger Lake's new unique ACPI device IDs for DPTF and fan drivers are
> not
> valid as the IDs are missing 'C'. Fix the IDs by updating them.
> 
> After the update, the new IDs should now look like
> INT1047 --> INTC1047
> INT1040 --> INTC1040
> INT1043 --> INTC1043
> INT1044 --> INTC1044
> 
We need Fixes tag.

For example

Fixes: 55cfe6a5c582 ("ACPI: DPTF: Add Tiger Lake ACPI device IDs")
Cc: 5.6+ <stable@vger.kernel.org> # 5.6+

By the time this patch is merged I guess the 5.6 will be out.

> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Suggested-by: Srinivas Pandruvada <srinivas.pandruvada@intel.com>
> Signed-off-by: Gayatri Kammela <gayatri.kammela@intel.com>
> ---
>  drivers/acpi/device_pm.c            | 2 +-
>  drivers/acpi/dptf/dptf_power.c      | 2 +-
>  drivers/acpi/dptf/int340x_thermal.c | 8 ++++----
>  3 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/acpi/device_pm.c b/drivers/acpi/device_pm.c
> index b64c62bfcea5..80dae3b3c36a 100644
> --- a/drivers/acpi/device_pm.c
> +++ b/drivers/acpi/device_pm.c
> @@ -1321,7 +1321,7 @@ int acpi_dev_pm_attach(struct device *dev, bool
> power_on)
>  	 */
>  	static const struct acpi_device_id special_pm_ids[] = {
>  		{"PNP0C0B", }, /* Generic ACPI fan */
> -		{"INT1044", }, /* Fan for Tiger Lake generation */
> +		{"INTC1044", }, /* Fan for Tiger Lake generation */
>  		{"INT3404", }, /* Fan */
>  		{}
>  	};
> diff --git a/drivers/acpi/dptf/dptf_power.c
> b/drivers/acpi/dptf/dptf_power.c
> index 387f27ef3368..e5fb34bfa52c 100644
> --- a/drivers/acpi/dptf/dptf_power.c
> +++ b/drivers/acpi/dptf/dptf_power.c
> @@ -97,7 +97,7 @@ static int dptf_power_remove(struct platform_device
> *pdev)
>  }
>  
>  static const struct acpi_device_id int3407_device_ids[] = {
> -	{"INT1047", 0},
> +	{"INTC1047", 0},
>  	{"INT3407", 0},
>  	{"", 0},
>  };
> diff --git a/drivers/acpi/dptf/int340x_thermal.c
> b/drivers/acpi/dptf/int340x_thermal.c
> index 1ec7b6900662..29b5c77256dd 100644
> --- a/drivers/acpi/dptf/int340x_thermal.c
> +++ b/drivers/acpi/dptf/int340x_thermal.c
> @@ -13,10 +13,10 @@
>  
>  #define INT3401_DEVICE 0X01
>  static const struct acpi_device_id int340x_thermal_device_ids[] = {
> -	{"INT1040"},
> -	{"INT1043"},
> -	{"INT1044"},
> -	{"INT1047"},
> +	{"INTC1040"},
> +	{"INTC1043"},
> +	{"INTC1044"},
> +	{"INTC1047"},
>  	{"INT3400"},
>  	{"INT3401", INT3401_DEVICE},
>  	{"INT3402"},

  reply	other threads:[~2020-03-27 20:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27 20:24 [PATCH v1 0/3] Fixes: update Tiger Lake ACPI device IDs Gayatri Kammela
2020-03-27 20:24 ` [PATCH v1 1/3] ACPI: fix: Update " Gayatri Kammela
2020-03-27 20:37   ` Pandruvada, Srinivas [this message]
2020-03-27 20:45     ` Kammela, Gayatri
2020-03-27 20:24 ` [PATCH v1 2/3] platform/x86: intel-hid: fix: Update Tiger Lake ACPI device ID Gayatri Kammela
2020-03-27 20:24 ` [PATCH v1 3/3] thermal: int340x_thermal: fix: Update Tiger Lake ACPI device IDs Gayatri Kammela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e9c5faa9c4c873b6f5b5a8a526134cd92ef6a2a.camel@intel.com \
    --to=srinivas.pandruvada@intel.com \
    --cc=alex.hung@canonical.com \
    --cc=amit.kucheria@verdurent.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=charles.d.prestopine@intel.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=dvhart@infradead.org \
    --cc=gayatri.kammela@intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mika.westerberg@intel.com \
    --cc=peterz@infradead.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox