From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5851C388F9 for ; Tue, 3 Nov 2020 14:43:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90999223EA for ; Tue, 3 Nov 2020 14:43:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PXOaHeUe" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727742AbgKCOnU (ORCPT ); Tue, 3 Nov 2020 09:43:20 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46423 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727812AbgKCOnU (ORCPT ); Tue, 3 Nov 2020 09:43:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604414597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5mR94CtgWfX16O/SpjDT08lGK3dRF6sKcQaYeJv7my8=; b=PXOaHeUegWzb7tM0IUEf7zw4oqhg2R+HOyWsG9wfhKryHfKu4MNDoEa5gyyMc0S/qljCVr ClVGmBadSwxobGTJYFxt+U0IZ+pdeWPWJsQmT4UzW5l+w0B/1I95gjsREEUI1kYOULnvU/ dQkJy3gAfzZtmp9t4U8PdFtnHy1WNkE= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-89-l4Heb8_IMWaIOD-3iXPaeQ-1; Tue, 03 Nov 2020 09:43:07 -0500 X-MC-Unique: l4Heb8_IMWaIOD-3iXPaeQ-1 Received: by mail-ej1-f72.google.com with SMTP id nt22so2459664ejb.17 for ; Tue, 03 Nov 2020 06:43:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5mR94CtgWfX16O/SpjDT08lGK3dRF6sKcQaYeJv7my8=; b=f9emBPHOgR/v6DAZj78AxctGlLgzY0ymMZ+vWts0Pd2C1tq/B/7qbaefxdVbV2uqdZ Fba1eUoC9A6xdvAsTyWuTyqTamWv22KRmwPfLG9VJ7RZ2wrmJn1G2zj/Pjb15RxrUStE cT07z5QMw5Cde9Hy0kv7effLtc6kJ40pFjqkTp9/vgZShBjjhOLcy9FmdextIlnaw40u uWGj1EBOd6JoBwQMrOU30LL/s3j62vYVuAKPSyggoNPHSvhebSB8b8N6UMth+DfN8Gni MR8ZBhUCD0Sl57gM2BSqZ+DP5lDE1hdz+TkdPGZrXEgpeWGe7Z/UE7H9jrsTTJA7QdC1 +/iw== X-Gm-Message-State: AOAM533iqLDRdxSyDueRhurLLpnc7y+EMcniq6C1zig8bsG3GO8RHi+a INncsR/cfWCudVnok3Zm23AKBvV6Un2X8D6pPGyO+UUQGguHlRdgwjUPRxT9fVQbM4AOgDYtDwu ZQRfenaIJ4bwXYnszzTEPb5hhQ1ixvy7Csg== X-Received: by 2002:a17:906:9719:: with SMTP id k25mr12152007ejx.226.1604414586117; Tue, 03 Nov 2020 06:43:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJxrRkmHwnwcEV4hRn43EG1AqdaDKUUd8g2tC2njIEKYc/4fGm4XiRj2rrbBL/O0BoqJCDs5JA== X-Received: by 2002:a17:906:9719:: with SMTP id k25mr12151989ejx.226.1604414585903; Tue, 03 Nov 2020 06:43:05 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c0c-fe00-6c10-fbf3-14c4-884c.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:6c10:fbf3:14c4:884c]) by smtp.gmail.com with ESMTPSA id u26sm11919269edt.39.2020.11.03.06.43.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Nov 2020 06:43:05 -0800 (PST) Subject: Re: [hp_wmi] Recieving same keycode from two keys To: Rhys Perry , =?UTF-8?Q?Barnab=c3=a1s_P=c5=91cze?= References: <9bb85a72-cb91-c0af-8289-dd8601f5b71b@redhat.com> Cc: Platform Driver From: Hans de Goede Message-ID: <80d43b00-09d3-9f15-d8d6-a4264cf68dd2@redhat.com> Date: Tue, 3 Nov 2020 15:43:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org Hi, Note I restored the Cc list again, please use Reply-to-all. On 11/3/20 3:25 PM, Rhys Perry wrote: >> >> Hi, >> >> On 11/3/20 2:35 PM, Rhys Perry wrote: >>>>>>>> (please use reply-all so that the mailing list gets the emails as well) >>>> >>> >>> Oh, my mistake. I didn't actually know the difference between the two. >>> Sorry for any confusion this might cause in the future. >>> >>>> >>>>>> [...] >>>>>>>> Can you see any messages generated by the hp-wmi driver when these key presses occur? >>>>>>> >>>>>>> Not that I know of, unless there is some sort of debug mode that can be enabled >>>>>>> >>>>>>>>>> Now, this is not that interesting at first, I obviously just need to >>>>>>>>>> map a keycode. The confusing part is that for both the brightness up >>>>>>>>>> AND the brightness down key I get the same code (e02b). I am not to >>>>>>>>>> sure how to debug this behavior but I would appreciate if someone >>>>>>>>>> helped investigate this issue. >>>>>>>>>> I am not sure if this is relevant, but my RFKILL key does not work >>>>>>>>>> either (but does not show anything in journal). >>>>>>>> >>>>>>>> Could you please run `evtest` and see if you have a "HP WMI hotkeys" input device? >>>>>>>> If so, please select it, and then press the function keys and see if any events appear. >>>>>>> >>>>>>> After running`evtest` there is a device called "HP WMI hotkeys" (on >>>>>>> /dev/input/event16). However, after selecting it and pressing the >>>>>>> brightness keys no events appear. >>>>>>> >>>>>>>> Furthermore, you could install `acpid`, start it (something along the lines of >>>>>>>> `sudo systemctl start acpid`), then run `acpi_listen` and see if you get anything >>>>>>>> when you press the keys. >>>>>>> >>>>>>> After starting the service and running`acpi_listen`, no events appear >>>>>>> when pressing the brightness keys >>>>>>> >>>>>>>>>> Here is a link to acpidump: >>>>>>>>>> https://www.dropbox.com/s/ulyltq0gz35s79l/acpidump?dl=0 >>>>>>>>>> ::: Rhys Perry ::: >>>>>>> [...] >>>>>> >>>>>> Could you test other function keys like volume up/down, etc.? >>>>>> >>>>> After running some tests with evtest I have found out: >>>>> - Brightness keys: "AT Translated Set 2 keyboard" (although same keycode) >>>>> - Volume keys: "AT Translated Set 2 keyboard" >>>>> - Media keys: "AT Translated Set 2 keyboard" >>>>> - RFKILL key: (none, although there is a device called "HP Wireless hotkeys") >>>> >>>> Please install the `evemu` program suite, and run `evemu-record /dev/input/event...` >>>> for the AT keyboard, HP WMI hotkeys, and HP Wireless hotkeys; in each run press the >>>> brightness up/down, volume up/down keys in any fixed order you like, and then send >>>> the output of each run (including the part that is initially printed before >>>> receiving any events). Could you also run `acpi_listen` at the same time and >>>> see if any key presses are registered there? If yes, what was the output? >>>> >>> >>> Ok, here you go: >>> "AT Translated Set 2 Keyboard": https://0x0.st/idpK.txt >>> "HP Wireless hotkeys": https://0x0.st/idpP.txt >>> "HP WMI hotkeys": https://0x0.st/idpN.txt >>> `acpi_listen`: https://0x0.st/idpb.txt >> >> Can you also run evemu-record for the "Video Bus" >> input device and check if you get events there for the >> brightness up/down key presses? On modern laptops events >> for the brightness keys are typically delivered there. >> > > I ran evemu-record for my "Video Bus" devices (of which I had two) and > there was nothing on those either. I quickly ran over every single > input device and I can confirm that "AT Translated Set 2 Keyboard" is > the only one that responds to brightness keys. Hmm, ok, weird. Usually at least something is generating events for this. Often we have the problem that we get the brightness keys reported by multiple input devices, this is a new problem. Can you try adding: wmi.debug_event=1 To your kernel commandline and then after rebooting do: cat /proc/cmdline To check that it really is there and then do: dmesg -w To monitor kernel messages and then press the brightness up/down hotkeys and see if you get any new messages ? >> Also are you perhaps using the nvidia binary driver for >> your GPU ? >> > > No, I am running with nouveau. Most of the performance isn't there, as > they haven't worked out reclocking on the 1050Ti yet, but it's enough > for what I do. Ok, good, then at least the nvidia binary driver is not getting in the way. Regards, Hans