Re: [RFC 03/10] platform/x86/intel/ifs: Add driver for In-Field Scan

Joseph, Jithu
2022-03-03T02:05:50Z

On 3/2/2022 3:24 PM, Williams, Dan J wrote:

>
> I don't see any need to include author info in source files, that's
> what 'git blame' is for.

Noted. Will remove it then

>> +
>> +MODULE_LICENSE("GPL");
>> +MODULE_INFO(name, "ifs");
>> +MODULE_DESCRIPTION("ifs");
>
> Just omit MODULE_INFO and MODULE_DESCRIPTION if nothing of importance
> needs to be added.

Will try to be more informative and descriptive

>
>> +module_init(ifs_init);
>> +module_exit(ifs_exit);
>> diff --git a/drivers/platform/x86/intel/ifs/ifs.h b/drivers/platform/x86/intel/ifs/ifs.h
>> new file mode 100644
>> index 000000000000..f3f924fced06
>> --- /dev/null
>> +++ b/drivers/platform/x86/intel/ifs/ifs.h
>> @@ -0,0 +1,14 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> +/* Copyright(c) 2021 Intel Corporation.
>> + *
>> + * Author: Jithu Joseph <jithu.joseph@intel.com>
>> + */
>> +
>> +#ifndef _IFS_H_
>> +#define _IFS_H_
>> +
>> +/* These bits are in the IA32_CORE_CAPABILITIES MSR */
>> +#define MSR_IA32_CORE_CAPS_INTEGRITY_BIT       2
>> +#define MSR_IA32_CORE_CAPS_INTEGRITY           BIT(MSR_IA32_CORE_CAPS_INTEGRITY_BIT)
>
> Is this header going to grow any more definitions? Otherwise these 2
> lines can just move into the source file.

Subsequent patches adds more definitions to this header.

Jithu