Re: [RFC 00/10] Introduce In Field Scan driver

Greg KH
2022-03-01T20:14:44Z

On Tue, Mar 01, 2022 at 09:10:20PM +0100, Greg KH wrote:
> On Tue, Mar 01, 2022 at 11:54:47AM -0800, Jithu Joseph wrote:
> > Note to Maintainers:
> > Requesting x86 Maintainers to take a look at patch01 as it
> > touches arch/x86 portion of the kernel. Also would like to guide them
> > to patch07 which sets up hotplug notifiers and creates kthreads.
> >
> > Patch 2/10 - Adds Documentation. Requesting Documentation maintainer to review it.
> >
> > Requesting Greg KH to review the sysfs changes added by patch08.
>
> "RFC" means you are not comfortable submitting the changes yet, so you
> don't need my review at this point in time. Become confident in your
> changes before asking for others to review the code please.

Hint, it needs work, sysfs_emit() for one thing, lack of reference
counting on your cpu objects is another...