From: "Bjørn Mork" <bjorn@mork.no>
To: Darren Hart <dvhart@infradead.org>
Cc: "qipeng.zha" <qipeng.zha@intel.com>,
platform-driver-x86@vger.kernel.org, fei.yang@intel.com,
huiquan.zhong@intel.com, jason.cj.chen@intel.com,
qi.zheng@intel.com,
One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
Jacob Pan <jacob.jun.pan@intel.com>
Subject: Re: [PATCH v4] platform:x86: add Intel Broxton PMC IPC driver
Date: Wed, 27 May 2015 10:36:58 +0200 [thread overview]
Message-ID: <87oal6mn6d.fsf@nemi.mork.no> (raw)
In-Reply-To: <20150527060240.GA2681@fury.dvhart.com> (Darren Hart's message of "Tue, 26 May 2015 23:02:40 -0700")
Darren Hart <dvhart@infradead.org> writes:
>> +static DEVICE_ATTR(simplecmd, S_IWUSR | S_IRUSR,
>> + NULL,
>> + intel_pmc_ipc_simple_cmd_store);
>> +static DEVICE_ATTR(northpeak, S_IWUSR | S_IRUSR,
>> + NULL,
>> + intel_pmc_ipc_northpeak_store);
>> +
>> +static struct attribute *intel_ipc_attrs[] = {
>> + &dev_attr_northpeak.attr,
>> + &dev_attr_simplecmd.attr,
>> + NULL
>> +};
>
>
> Please use the DEVICE_ATTR_RW macro.
Minor nit-nit: Those attributes don't have any "show" function so you
cannot use DEVICE_ATTR_RW. If they really are not intended to be
readable, then the DEVICE_ATTR_WO macro could be used for that.
Bjørn
prev parent reply other threads:[~2015-05-27 8:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 13:47 [PATCH v4] platform:x86: add Intel Broxton PMC IPC driver qipeng.zha
2015-05-27 6:02 ` Darren Hart
2015-05-27 8:36 ` Bjørn Mork [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oal6mn6d.fsf@nemi.mork.no \
--to=bjorn@mork.no \
--cc=dvhart@infradead.org \
--cc=fei.yang@intel.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=huiquan.zhong@intel.com \
--cc=jacob.jun.pan@intel.com \
--cc=jason.cj.chen@intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qi.zheng@intel.com \
--cc=qipeng.zha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox