Re: [PATCH v2 19/24] platform/x86: thinkpad_acpi: Switch to using sparse-keymap helpers

[Hans de Goede <hdegoede@redhat.com>]

Hi Vlastimil,

On 5/22/24 1:50 PM, Vlastimil Babka wrote:
> On 4/24/24 2:28 PM, Hans de Goede wrote:
>> Switch the hotkey keymap handling over to the sparse-keymap helpers,
>> there should be no functional changes from this.
>>
>> Note all the mappings to KEY_UNKNOWN are removed since that is the default
>> behavior of sparse_keymap_report_event() for unknown scancodes.
>>
>> Also drop the big comment about making changes to the keymaps since
>> the contents of that comment are mostly obsolete.
>>
>> Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> Hi,
> 
> I believe this is what gave me the following error compiling current
> Linus's master:
> 
> ERROR: modpost: "sparse_keymap_report_event"
> [drivers/platform/x86/thinkpad_acpi.ko] undefined!
> ERROR: modpost: "sparse_keymap_setup"
> [drivers/platform/x86/thinkpad_acpi.ko] undefined!
> 
> probably config THINKPAD_ACPI now has to depend/select INPUT_SPARSEKMAP?
> It's fixed when I configure it =m manually.

Thank you for reporting this. This should be fixed by:

https://lore.kernel.org/platform-driver-x86/20240522074813.379b9fc2@gandalf.local.home/T/#u

Which I will include in my next pdx86 fixes pull-request to Linus.

Regards,

Hans