Re: [PATCH] platform/x86: Switch back to struct platform_driver::remove()

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1990 bytes --]

On Fri, 18 Oct 2024, Uwe Kleine-König wrote:

> Hello Ilpo,
> 
> On Thu, Oct 17, 2024 at 12:52:44PM +0300, Ilpo Järvinen wrote:
> > On Thu, 17 Oct 2024, Uwe Kleine-König wrote:
> > > After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> > > return void") .remove() is (again) the right callback to implement for
> > > platform drivers.
> > > 
> > > Convert all platform drivers below drivers/platform/x86/ to use
> > > .remove(), with the eventual goal to drop struct
> > > platform_driver::remove_new(). As .remove() and .remove_new() have the
> > > same prototypes, conversion is done by just changing the structure
> > > member name in the driver initializer.
> > > 
> > > While touching these files, make indention of the struct initializer
> > > consistent in several files.
> > 
> > Thanks.
> > 
> > I've applied this patch now to review-ilpo branch, it applied conflict 
> > free (unsurprisingly).
> 
> Thanks.
> 
> > Next time, please make PATCH x/y out of indentation or any other unrelated 
> > change (I'm happy to take them too). I often validate large-scale 
> > mechanical changes like this using tools because it's harder to fool 
> > a pattern matcher than my eyes/mind. Any unrelated change creates noise
> > I have to deal with.
> 
> I'll try to remember. But I already now ask for forgiveness because in
> my experience trivial whitespace only changes are not so well received
> by most maintainers and in the past I was asked to squash these cleanups
> into the functional patches. Do you know about git show -b (and diff
> -b)?

This was not a functional patch but large-scale mechanical change (ie., no 
function changes).

I understand it might be hard to navigate various preferences of different 
maintainers (and I took your patch anyway so I can hopefully remain
reasonable next time too :-)).

I know about -b, -B, and --word-diff (these are actually among "tools" I 
use per usecase).

-- 
 i.