From: Markus Elfring <Markus.Elfring@web.de>
To: Kurt Borja <kuurtb@gmail.com>,
platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com
Cc: LKML <linux-kernel@vger.kernel.org>,
"Armin Wolf" <W_Armin@gmx.de>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Mario Limonciello" <mario.limonciello@amd.com>
Subject: Re: [PATCH 4/5] alienware-wmi: Fix module init error handling
Date: Tue, 19 Nov 2024 15:55:08 +0100 [thread overview]
Message-ID: <940b49da-cbca-42d4-9a80-501465bc8cbe@web.de> (raw)
In-Reply-To: <20241119043523.25650-1-kuurtb@gmail.com>
> Propagate led_classdev_register return value in case of error.
> Call led_classdev_unregister in case sysfs_create_group fails.
>
> If alienware_zone_init fails, alienware_zone_exit should not be called
> because the latter unregisters/removes the led class and the sysfs
> group, which may not be registered/created if the former failed
> prematurely.
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12#n145
Regards,
Markus
next prev parent reply other threads:[~2024-11-19 14:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 4:35 [PATCH 4/5] alienware-wmi: Fix module init error handling Kurt Borja
2024-11-19 14:55 ` Markus Elfring [this message]
2024-11-19 16:06 ` Kurt Borja
2024-11-19 16:22 ` Ilpo Järvinen
2024-11-19 19:01 ` Kurt Borja
2024-11-19 16:06 ` Mario Limonciello
2024-11-19 16:11 ` Kurt Borja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=940b49da-cbca-42d4-9a80-501465bc8cbe@web.de \
--to=markus.elfring@web.de \
--cc=Dell.Client.Kernel@dell.com \
--cc=W_Armin@gmx.de \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kuurtb@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox