From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] platform: x86: remove redundant variable in hp-wireless.c Date: Sat, 08 Nov 2014 00:03:23 +0100 Message-ID: <9503707.R8535QTB05@vostro.rjw.lan> References: <1415144839-2035-1-git-send-email-giedriuswork@gmail.com> <20141107182822.GA62564@vmdeb7> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20141107182822.GA62564@vmdeb7> Sender: linux-acpi-owner@vger.kernel.org To: Darren Hart Cc: Giedrius Statkevicius , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Linux ACPI Mailing List List-Id: platform-driver-x86.vger.kernel.org On Friday, November 07, 2014 10:28:23 AM Darren Hart wrote: > On Wed, Nov 05, 2014 at 01:47:19AM +0200, Giedrius Statkevicius wrote= : > > Remove a variable because it only holds the results of a function c= all > > and then gets returned so instead just return the result of a funct= ion > > call. > >=20 > > Signed-off-by: Giedrius Statkevi=C4=8Dius > > --- > > drivers/platform/x86/hp-wireless.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > >=20 > > diff --git a/drivers/platform/x86/hp-wireless.c b/drivers/platform/= x86/hp-wireless.c > > index 415348f..670c62b 100644 > > --- a/drivers/platform/x86/hp-wireless.c > > +++ b/drivers/platform/x86/hp-wireless.c > > @@ -82,10 +82,7 @@ static void hpwl_notify(struct acpi_device *acpi= _dev, u32 event) > > =20 > > static int hpwl_add(struct acpi_device *device) > > { > > - int err; > > - > > - err =3D hp_wireless_input_setup(); > > - return err; > > + return hp_wireless_input_setup(); >=20 > Since acpi_device_probe() does not print a warning if add() fails, it= might be > preferable to print the message here, rather than ignoring it complet= ely. >=20 > Rafael? Sounds reasonable. --=20 I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html