X86 platform drivers
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: michaelsh@nvidia.com
Cc: platform-driver-x86@vger.kernel.org, vadimp@nvidia.com
Subject: Re: [PATCH 1/1] platform/mellanox: Remove unused variable.
Date: Thu, 12 May 2022 15:35:26 +0200	[thread overview]
Message-ID: <97a97e6a-9ecc-b22b-941c-7c537badaea9@redhat.com> (raw)
In-Reply-To: <20220511195043.54853-1-michaelsh@nvidia.com>

Hi,

On 5/11/22 21:50, michaelsh@nvidia.com wrote:
> From: Michael Shych <michaelsh@nvidia.com>
> 
> Fix problem of set but unused variable.
> 
> Fixes: 9e267f050444f ("platform/mellanox: Add support for new SN2201 system")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Michael Shych <michaelsh@nvidia.com>

Thanks, note since I needed to rebase my review-hans branch for another
issue anyways I've squashed this into the original:

"platform/mellanox: Add support for new SN2201 system"

commit which introduced this problem.

Regards,

Hans


> ---
>  drivers/platform/mellanox/nvsw-sn2201.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/mellanox/nvsw-sn2201.c b/drivers/platform/mellanox/nvsw-sn2201.c
> index 6165e0154424..0bcdc7c75007 100644
> --- a/drivers/platform/mellanox/nvsw-sn2201.c
> +++ b/drivers/platform/mellanox/nvsw-sn2201.c
> @@ -939,7 +939,7 @@ static int nvsw_sn2201_config_post_init(struct nvsw_sn2201 *nvsw_sn2201)
>  	struct mlxreg_hotplug_device *sn2201_dev;
>  	struct i2c_adapter *adap;
>  	struct device *dev;
> -	int i, j, err;
> +	int i, err;
>  
>  	dev = nvsw_sn2201->dev;
>  	adap = i2c_get_adapter(nvsw_sn2201->main_mux_deferred_nr);
> @@ -952,7 +952,7 @@ static int nvsw_sn2201_config_post_init(struct nvsw_sn2201 *nvsw_sn2201)
>  
>  	/* Update board info. */
>  	sn2201_dev = nvsw_sn2201->sn2201_devs;
> -	for (i = 0, j = 0; i < nvsw_sn2201->sn2201_devs_num; i++, sn2201_dev++) {
> +	for (i = 0; i < nvsw_sn2201->sn2201_devs_num; i++, sn2201_dev++) {
>  		sn2201_dev->adapter = i2c_get_adapter(sn2201_dev->nr);
>  		if (!sn2201_dev->adapter)
>  			return -ENODEV;


  reply	other threads:[~2022-05-12 13:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11 19:50 [PATCH 1/1] platform/mellanox: Remove unused variable michaelsh
2022-05-12 13:35 ` Hans de Goede [this message]
2022-05-12 13:37   ` Michael Shych

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97a97e6a-9ecc-b22b-941c-7c537badaea9@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=michaelsh@nvidia.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=vadimp@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox