From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8A0D5242 for ; Sun, 14 Jan 2024 16:57:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Pr/xMT6k" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a271a28aeb4so869860766b.2 for ; Sun, 14 Jan 2024 08:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1705251466; x=1705856266; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1pM/OkGjC0LrgIJMrmwxWzyE3jmZ/B0QUrkDHT91qcw=; b=Pr/xMT6k0j3rGYTvYTurZKE5rHaiNhVKj/7APdAKsA2wbziU4HQq4sXh82X/vKAeVC xn2XsKzDYtxWkNbHB81ve0WYl00P1+2Elih3168y7G7Z7B5MKlJ3MPK650zSnDwthNvh 6lQF/R+BVUwGTfV/WaXmypiNP4+Qs7CN4Q44+RjH72IcmCipmIqPcFZ3s0qm4iHQ2SV+ 1onYjA6TmbqOAIOh9Yx53OK/WBE5ziHvKoAxbVMem+NrWJtPNV/VM2kbFBvrv3T0sulr iQQMDV+K3P45EVeBDjWpfwfDpl7ztVRqLHHmJPSy29Anq5YntIwjwDcmEfgrcG5IRsvw 2Qqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705251466; x=1705856266; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1pM/OkGjC0LrgIJMrmwxWzyE3jmZ/B0QUrkDHT91qcw=; b=qaIOnlbKxuE9zBGDBX+zZuNwl0Y8ZFAyK3Odata+zVjxcLJn9PYiU1nDBLOy06Zqvu dU3Y8Wg9a5sgf+iK0yyl4wGDc8QsgR/VimnbPBp7j4tTqEXMz5GXPuq5FHFdkY8FgZC+ KBHDXXwI2mzMRiQMaQ0PO8eN18Gxja3jLact3MSS5Vf3Hr59xORHy/tPdhtIBHTuxCR8 GOzCfe5UMx2rrP8P04pdMIJb3YMUbUxjx5tmxQd5YBLCSFGmyHI8r922fodR+EtYDKCW Sbk4QwIZNuCFp00XMLTSeArB6g2liujY8hRjxeoKEa4h4zNaGw+Ofne1pWwMthhLXy6v zS5A== X-Gm-Message-State: AOJu0YyKNj2OEGpf3HtTRyjxiaY76gSZ5ZZSqcnZMa4R5kJuv9LgS3Jb WoC2wyXNo0yGQpp0JLMT6vY= X-Google-Smtp-Source: AGHT+IGJoEFKATF7uvjFFIp8Fk6TXoekq7rtzlvjBjUISdaGs0EhQopMlEeIYGwDpZPHvKj5GRNDDw== X-Received: by 2002:a17:906:318a:b0:a2b:9580:c447 with SMTP id 10-20020a170906318a00b00a2b9580c447mr2266391ejy.110.1705251465278; Sun, 14 Jan 2024 08:57:45 -0800 (PST) Received: from ?IPV6:2a01:c22:73ca:7c00:6976:809d:3eab:4a9? (dynamic-2a01-0c22-73ca-7c00-6976-809d-3eab-04a9.c22.pool.telefonica.de. [2a01:c22:73ca:7c00:6976:809d:3eab:4a9]) by smtp.googlemail.com with ESMTPSA id y20-20020a170906471400b00a29430458efsm4317027ejq.65.2024.01.14.08.57.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 14 Jan 2024 08:57:44 -0800 (PST) Message-ID: <9fa8ccdb-76b4-45d1-b3a3-3aa1ff74d448@gmail.com> Date: Sun, 14 Jan 2024 17:57:45 +0100 Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] platform/x86: remove obsolete calls to ledtrig_audio_get Content-Language: en-US To: Hans de Goede , Corentin Chary , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Matthew Garrett , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Perry Yuan , Henrique de Moraes Holschuh Cc: acpi4asus-user@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com, ibm-acpi-devel@lists.sourceforge.net References: <3979bfb3-2cdc-4dce-a500-03c98c943eb7@redhat.com> From: Heiner Kallweit Autocrypt: addr=hkallweit1@gmail.com; keydata= xsFNBF/0ZFUBEAC0eZyktSE7ZNO1SFXL6cQ4i4g6Ah3mOUIXSB4pCY5kQ6OLKHh0FlOD5/5/ sY7IoIouzOjyFdFPnz4Bl3927ClT567hUJJ+SNaFEiJ9vadI6vZm2gcY4ExdIevYHWe1msJF MVE4yNwdS+UsPeCF/6CQQTzHc+n7DomE7fjJD5J1hOJjqz2XWe71fTvYXzxCFLwXXbBiqDC9 dNqOe5odPsa4TsWZ09T33g5n2nzTJs4Zw8fCy8rLqix/raVsqr8fw5qM66MVtdmEljFaJ9N8 /W56qGCp+H8Igk/F7CjlbWXiOlKHA25mPTmbVp7VlFsvsmMokr/imQr+0nXtmvYVaKEUwY2g 86IU6RAOuA8E0J5bD/BeyZdMyVEtX1kT404UJZekFytJZrDZetwxM/cAH+1fMx4z751WJmxQ J7mIXSPuDfeJhRDt9sGM6aRVfXbZt+wBogxyXepmnlv9K4A13z9DVLdKLrYUiu9/5QEl6fgI kPaXlAZmJsQfoKbmPqCHVRYj1lpQtDM/2/BO6gHASflWUHzwmBVZbS/XRs64uJO8CB3+V3fa cIivllReueGCMsHh6/8wgPAyopXOWOxbLsZ291fmZqIR0L5Y6b2HvdFN1Xhc+YrQ8TKK+Z4R mJRDh0wNQ8Gm89g92/YkHji4jIWlp2fwzCcx5+lZCQ1XdqAiHQARAQABzSZIZWluZXIgS2Fs bHdlaXQgPGhrYWxsd2VpdDFAZ21haWwuY29tPsLBjgQTAQgAOBYhBGxfqY/yOyXjyjJehXLe ig9U8DoMBQJf9GRVAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEHLeig9U8DoMSycQ AJbfg8HZEK0ljV4M8nvdaiNixWAufrcZ+SD8zhbxl8GispK4F3Yo+20Y3UoZ7FcIidJWUUJL axAOkpI/70YNhlqAPMsuudlAieeYZKjIv1WV5ucNZ3VJ7dC+dlVqQdAr1iD869FZXvy91KhJ wYulyCf+s4T9YgmLC6jLMBZghKIf1uhSd0NzjyCqYWbk2ZxByZHgunEShOhHPHswu3Am0ftt ePaYIHgZs+Vzwfjs8I7EuW/5/f5G9w1vibXxtGY/GXwgGGHRDjFM7RSprGOv4F5eMGh+NFUJ TU9N96PQYMwXVxnQfRXl8O6ffSVmFx4H9rovxWPKobLmqQL0WKLLVvA/aOHCcMKgfyKRcLah 57vGC50Ga8oT2K1g0AhKGkyJo7lGXkMu5yEs0m9O+btqAB261/E3DRxfI1P/tvDZpLJKtq35 dXsj6sjvhgX7VxXhY1wE54uqLLHY3UZQlmH3QF5t80MS7/KhxB1pO1Cpcmkt9hgyzH8+5org +9wWxGUtJWNP7CppY+qvv3SZtKJMKsxqk5coBGwNkMms56z4qfJm2PUtJQGjA65XWdzQACib 2iaDQoBqGZfXRdPT0tC1H5kUJuOX4ll1hI/HBMEFCcO8++Bl2wcrUsAxLzGvhINVJX2DAQaF aNetToazkCnzubKfBOyiTqFJ0b63c5dqziAgzsFNBF/0ZFUBEADF8UEZmKDl1w/UxvjeyAeX kghYkY3bkK6gcIYXdLRfJw12GbvMioSguvVzASVHG8h7NbNjk1yur6AONfbUpXKSNZ0skV8V fG+ppbaY+zQofsSMoj5gP0amwbwvPzVqZCYJai81VobefTX2MZM2Mg/ThBVtGyzV3NeCpnBa 8AX3s9rrX2XUoCibYotbbxx9afZYUFyflOc7kEpc9uJXIdaxS2Z6MnYLHsyVjiU6tzKCiVOU KJevqvzPXJmy0xaOVf7mhFSNQyJTrZpLa+tvB1DQRS08CqYtIMxRrVtC0t0LFeQGly6bOngr ircurWJiJKbSXVstLHgWYiq3/GmCSx/82ObeLO3PftklpRj8d+kFbrvrqBgjWtMH4WtK5uN5 1WJ71hWJfNchKRlaJ3GWy8KolCAoGsQMovn/ZEXxrGs1ndafu47yXOpuDAozoHTBGvuSXSZo ythk/0EAuz5IkwkhYBT1MGIAvNSn9ivE5aRnBazugy0rTRkVggHvt3/7flFHlGVGpBHxFUwb /a4UjJBPtIwa4tWR8B1Ma36S8Jk456k2n1id7M0LQ+eqstmp6Y+UB+pt9NX6t0Slw1NCdYTW gJezWTVKF7pmTdXszXGxlc9kTrVUz04PqPjnYbv5UWuDd2eyzGjrrFOsJEi8OK2d2j4FfF++ AzOMdW09JVqejQARAQABwsF2BBgBCAAgFiEEbF+pj/I7JePKMl6Fct6KD1TwOgwFAl/0ZFUC GwwACgkQct6KD1TwOgxUfg//eAoYc0Vm4NrxymfcY30UjHVD0LgSvU8kUmXxil3qhFPS7KA+ y7tgcKLHOkZkXMX5MLFcS9+SmrAjSBBV8omKoHNo+kfFx/dUAtz0lot8wNGmWb+NcHeKM1eb nwUMOEa1uDdfZeKef/U/2uHBceY7Gc6zPZPWgXghEyQMTH2UhLgeam8yglyO+A6RXCh+s6ak Wje7Vo1wGK4eYxp6pwMPJXLMsI0ii/2k3YPEJPv+yJf90MbYyQSbkTwZhrsokjQEaIfjrIk3 rQRjTve/J62WIO28IbY/mENuGgWehRlTAbhC4BLTZ5uYS0YMQCR7v9UGMWdNWXFyrOB6PjSu Trn9MsPoUc8qI72mVpxEXQDLlrd2ijEWm7Nrf52YMD7hL6rXXuis7R6zY8WnnBhW0uCfhajx q+KuARXC0sDLztcjaS3ayXonpoCPZep2Bd5xqE4Ln8/COCslP7E92W1uf1EcdXXIrx1acg21 H/0Z53okMykVs3a8tECPHIxnre2UxKdTbCEkjkR4V6JyplTS47oWMw3zyI7zkaadfzVFBxk2 lo/Tny+FX1Azea3Ce7oOnRUEZtWSsUidtIjmL8YUQFZYm+JUIgfRmSpMFq8JP4VH43GXpB/S OCrl+/xujzvoUBFV/cHKjEQYBxo+MaiQa1U54ykM2W4DnHb1UiEf5xDkFd4= In-Reply-To: <3979bfb3-2cdc-4dce-a500-03c98c943eb7@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 14.01.2024 17:34, Hans de Goede wrote: > Hi Heiner > > On 1/13/24 18:03, Heiner Kallweit wrote: >> Since 64f67b5240db ("leds: trigger: audio: Add an activate callback to >> ensure the initial brightness is set") the audio triggers have an >> activate callback which sets the LED brightness as soon as the >> (default) trigger is bound to the LED device. So we can remove the >> call to ledtrig_audio_get. >> >> Positive side effect: There's no code dependency to ledtrig-audio any >> longer. > > Thank you for your patch since these drivers now no longer > depend on the ledtrig-audio module can you please remove the: > > select LEDS_TRIGGERS > select LEDS_TRIGGER_AUDIO > > lines from the Kconfig bits for the modified drivers? > Sure. I thought about this, but wasn't sure whether the LED support is highly desirable from a functional point of view, what may have justified keeping the selects. > Regards, > > Hans > > > >> >> Signed-off-by: Heiner Kallweit >> --- >> drivers/platform/x86/asus-wmi.c | 1 - >> drivers/platform/x86/dell/dell-laptop.c | 2 -- >> drivers/platform/x86/dell/dell-wmi-privacy.c | 1 - >> drivers/platform/x86/huawei-wmi.c | 1 - >> drivers/platform/x86/thinkpad_acpi.c | 1 - >> 5 files changed, 6 deletions(-) >> >> diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c >> index 18be35fdb..21dee425e 100644 >> --- a/drivers/platform/x86/asus-wmi.c >> +++ b/drivers/platform/x86/asus-wmi.c >> @@ -1620,7 +1620,6 @@ static int asus_wmi_led_init(struct asus_wmi *asus) >> if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MICMUTE_LED)) { >> asus->micmute_led.name = "platform::micmute"; >> asus->micmute_led.max_brightness = 1; >> - asus->micmute_led.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE); >> asus->micmute_led.brightness_set_blocking = micmute_led_set; >> asus->micmute_led.default_trigger = "audio-micmute"; >> >> diff --git a/drivers/platform/x86/dell/dell-laptop.c b/drivers/platform/x86/dell/dell-laptop.c >> index 658643835..42f7de2b4 100644 >> --- a/drivers/platform/x86/dell/dell-laptop.c >> +++ b/drivers/platform/x86/dell/dell-laptop.c >> @@ -2252,7 +2252,6 @@ static int __init dell_init(void) >> if (dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE) && >> dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE) && >> !dell_privacy_has_mic_mute()) { >> - micmute_led_cdev.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE); >> ret = led_classdev_register(&platform_device->dev, &micmute_led_cdev); >> if (ret < 0) >> goto fail_led; >> @@ -2261,7 +2260,6 @@ static int __init dell_init(void) >> >> if (dell_smbios_find_token(GLOBAL_MUTE_DISABLE) && >> dell_smbios_find_token(GLOBAL_MUTE_ENABLE)) { >> - mute_led_cdev.brightness = ledtrig_audio_get(LED_AUDIO_MUTE); >> ret = led_classdev_register(&platform_device->dev, &mute_led_cdev); >> if (ret < 0) >> goto fail_backlight; >> diff --git a/drivers/platform/x86/dell/dell-wmi-privacy.c b/drivers/platform/x86/dell/dell-wmi-privacy.c >> index c517bd45d..4d94603f7 100644 >> --- a/drivers/platform/x86/dell/dell-wmi-privacy.c >> +++ b/drivers/platform/x86/dell/dell-wmi-privacy.c >> @@ -288,7 +288,6 @@ static int dell_privacy_leds_setup(struct device *dev) >> priv->cdev.max_brightness = 1; >> priv->cdev.brightness_set_blocking = dell_privacy_micmute_led_set; >> priv->cdev.default_trigger = "audio-micmute"; >> - priv->cdev.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE); >> return devm_led_classdev_register(dev, &priv->cdev); >> } >> >> diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c >> index 0ef1c46b6..dde139c69 100644 >> --- a/drivers/platform/x86/huawei-wmi.c >> +++ b/drivers/platform/x86/huawei-wmi.c >> @@ -310,7 +310,6 @@ static void huawei_wmi_leds_setup(struct device *dev) >> huawei->cdev.max_brightness = 1; >> huawei->cdev.brightness_set_blocking = &huawei_wmi_micmute_led_set; >> huawei->cdev.default_trigger = "audio-micmute"; >> - huawei->cdev.brightness = ledtrig_audio_get(LED_AUDIO_MICMUTE); >> huawei->cdev.dev = dev; >> huawei->cdev.flags = LED_CORE_SUSPENDRESUME; >> >> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c >> index c4895e9bc..d1c9f91fd 100644 >> --- a/drivers/platform/x86/thinkpad_acpi.c >> +++ b/drivers/platform/x86/thinkpad_acpi.c >> @@ -9285,7 +9285,6 @@ static int mute_led_init(struct ibm_init_struct *iibm) >> continue; >> } >> >> - mute_led_cdev[i].brightness = ledtrig_audio_get(i); >> err = led_classdev_register(&tpacpi_pdev->dev, &mute_led_cdev[i]); >> if (err < 0) { >> while (i--) >