Re: [PATCH 1/2] eeepc-wmi: add additional hotkeys

[Chris Bagwell <chris@cnpbagwell.com>]

On Mon, Oct 11, 2010 at 12:10 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Sunday, October 10, 2010 11:26:22 pm Corentin Chary wrote:
>> On Mon, Oct 11, 2010 at 3:48 AM,  <chris@cnpbagwell.com> wrote:
>> > From: Chris Bagwell <chris@cnpbagwell.com>
>> >
>> > Added 4 hotkeys using same keymap values as eeepc-latop.
>> > These are mousepad toggle, resolution change, screen off,
>> > and task manager.  These were tested on 1005PE and are the
>> > Fn-F3, F4, F7, and F9, respectively.
>> >
>> > Also, added a new hot key for power toggles (Fn-Space on 1005PE)
>> > and is meant to drive cpufv interface from userspace.
>> >
>> > Finally, added several keys to be ignored that are being emitted
>> > but do not mapped to any useful or documented hotkeys.  This is
>> > purely cosmetic to prevent uknown key reports on console/log files.
>> > These keys are reported on 1005PE's.
>>
>> What are exactly these keys ? Since they are probably some obscure Fn+
>> combo, and they are probably used on another model, I'm not sure we should
>> hide them.
>>
>> I'm still not happy with F13 for "disable touchpad" but I did the same
>> for other laptops,
>> and we don't have a key for that ATM.
>
> The most sensible way would be to add one then. We just need to decide if
> it should be a key or a switch.
>

Motivated by thread on linux-input "Touchpad toggle mess", I changed
Fn-F3(toggle touchpad) from KEY_F13 to KEY_F22  With Gnome 2.32
(Fedora 14), now magically my touchpad toggle works automagically.

So I'd like to submit a patch to change both eeepc-laptop and
eeepc-wmi to use KEY_F22 for toggle touchpad to get some immediate
benifit.  Any issues with this?  Is F13 doing anything useful by
default?

I know in this thread and in other thread Dmitry mentioned we should
make a KEY_TOUCHPAD_TOGGLE (or whatever name).  I'm probably just
smart enough to do that if preferred but don't think I'd be able to
take it to the next level and get it translated to
XF86XK_TouchpadToggle.  Help appreciate in that area.

Chris