From: Chris Chiu <chiu@endlessm.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Corentin Chary <corentin.chary@gmail.com>,
Darren Hart <dvhart@infradead.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
acpi4asus-user <acpi4asus-user@lists.sourceforge.net>,
Hans de Goede <hdegoede@redhat.com>,
Linux Upstreaming Team <linux@endlessm.com>
Subject: Re: [PATCH v3 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change
Date: Wed, 15 Aug 2018 17:49:15 +0800 [thread overview]
Message-ID: <CAB4CAwdZYAKEDeboMFVpp9fnKPbdNZWP=VqroOOPmvcYwinX3A@mail.gmail.com> (raw)
In-Reply-To: <CAHp75Veu9+vQPjq+1uWnaocobcHUBpkHKx6OfKW3-E_UeVtKfA@mail.gmail.com>
On Wed, Aug 15, 2018 at 5:45 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Wed, Aug 15, 2018 at 12:34 PM, Chris Chiu <chiu@endlessm.com> wrote:
>> On Mon, Jul 2, 2018 at 8:10 PM, Andy Shevchenko
>> <andy.shevchenko@gmail.com> wrote:
>>> On Wed, Jun 27, 2018 at 1:27 PM, Chris Chiu <chiu@endlessm.com> wrote:
>>>> On Wed, Jun 20, 2018 at 10:46 PM, Chris Chiu <chiu@endlessm.com> wrote:
>>>>> Make asus-wmi notify on hotkey kbd brightness changes, listen for
>>>>> brightness events and update the brightness directly in the driver.
>>>>> Create new do_kbd_led_set function for in-driver update, and leave
>>>>> kbd_led_set for original led_classdev call path.
>>>>>
>>>>> Update the brightness by led_classdev_notify_brightness_hw_changed.
>>>>> This will allow userspace to monitor (poll) for brightness changes
>>>>> on the LED without reporting via input keymapping.
>>>
>>> LGTM, I'm about to push it to my review and testing queue, so, we will
>>> have 1 day or so time to gather objections if any.
>>> Thanks!
>>>
>>
>> Gentle ping. How's the review so far? Maybe need more time for more info?
>
> Sorry, I thought we have no objections and I pushed it to our for-next
> quite time ago [1].
> Should I do something differently?
>
> [1]: http://git.infradead.org/linux-platform-drivers-x86.git/commitdiff/dbb3d78f61badeadc7448f9d88a070a76612860f
>
> --
> With Best Regards,
> Andy Shevchenko
It's good to know. Thank you.
Chris
prev parent reply other threads:[~2018-08-15 9:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 14:46 [PATCH v3 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change Chris Chiu
2018-06-20 14:46 ` [PATCH v3 2/2] platform/x86: asus-wmi: Add keyboard backlight toggle support Chris Chiu
2018-06-27 10:27 ` [PATCH v3 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change Chris Chiu
2018-07-02 12:10 ` Andy Shevchenko
2018-08-15 9:34 ` Chris Chiu
2018-08-15 9:45 ` Andy Shevchenko
2018-08-15 9:49 ` Chris Chiu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAB4CAwdZYAKEDeboMFVpp9fnKPbdNZWP=VqroOOPmvcYwinX3A@mail.gmail.com' \
--to=chiu@endlessm.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=andy.shevchenko@gmail.com \
--cc=corentin.chary@gmail.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).