From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Chiu Subject: Re: [PATCH v3 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change Date: Wed, 15 Aug 2018 17:49:15 +0800 Message-ID: References: <20180620144645.2084-1-chiu@endlessm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: Corentin Chary , Darren Hart , Linux Kernel , Platform Driver , acpi4asus-user , Hans de Goede , Linux Upstreaming Team List-Id: platform-driver-x86.vger.kernel.org On Wed, Aug 15, 2018 at 5:45 PM, Andy Shevchenko wrote: > On Wed, Aug 15, 2018 at 12:34 PM, Chris Chiu wrote: >> On Mon, Jul 2, 2018 at 8:10 PM, Andy Shevchenko >> wrote: >>> On Wed, Jun 27, 2018 at 1:27 PM, Chris Chiu wrote: >>>> On Wed, Jun 20, 2018 at 10:46 PM, Chris Chiu wrote: >>>>> Make asus-wmi notify on hotkey kbd brightness changes, listen for >>>>> brightness events and update the brightness directly in the driver. >>>>> Create new do_kbd_led_set function for in-driver update, and leave >>>>> kbd_led_set for original led_classdev call path. >>>>> >>>>> Update the brightness by led_classdev_notify_brightness_hw_changed. >>>>> This will allow userspace to monitor (poll) for brightness changes >>>>> on the LED without reporting via input keymapping. >>> >>> LGTM, I'm about to push it to my review and testing queue, so, we will >>> have 1 day or so time to gather objections if any. >>> Thanks! >>> >> >> Gentle ping. How's the review so far? Maybe need more time for more info? > > Sorry, I thought we have no objections and I pushed it to our for-next > quite time ago [1]. > Should I do something differently? > > [1]: http://git.infradead.org/linux-platform-drivers-x86.git/commitdiff/dbb3d78f61badeadc7448f9d88a070a76612860f > > -- > With Best Regards, > Andy Shevchenko It's good to know. Thank you. Chris