From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay12.grserver.gr (relay12.grserver.gr [88.99.38.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53D5831196A for ; Thu, 16 Oct 2025 12:28:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=88.99.38.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760617710; cv=none; b=q95KR0NUidfuPOdCZg+yZCdvSJiz5JHpYnI2SLS8A0xJj7if7R2c6OjAHgftdqhJGP9yEct1DivMD9nWFk3McKhYFT5pa21rkSwBXyJYQ5tX2ZwSmnxHRe858qaLqVowHagDBozZWSLcr/MGfzLgUFhSGsYHH5LBYIUAYhNM3MU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760617710; c=relaxed/simple; bh=81lWZ6mYy0MgOCyItC6FqTjObhD3vIvXdIO5NNnMNEU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=KsN2ZiVResjj3cbdRW1pQlQeyGG+fkNQgBwi3JcBZOdrg3W281zEEUQSBaoGuiJtjw0egEOGtKaCoQHxq6eEd4jL/bLOt9FTrYBd4R3t7JdDkm2X8CS6QbiOV5C51nNfw+94jfYSbgAFV9yYCM8DprWEqlrjs3iN5M3W3RtBAHs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=antheas.dev; spf=pass smtp.mailfrom=antheas.dev; dkim=temperror (0-bit key) header.d=antheas.dev header.i=@antheas.dev header.b=f6BYCf8W; arc=none smtp.client-ip=88.99.38.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=antheas.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=antheas.dev Authentication-Results: smtp.subspace.kernel.org; dkim=temperror (0-bit key) header.d=antheas.dev header.i=@antheas.dev header.b="f6BYCf8W" Received: from relay12 (localhost [127.0.0.1]) by relay12.grserver.gr (Proxmox) with ESMTP id 84E0ABDBF4 for ; Thu, 16 Oct 2025 15:28:26 +0300 (EEST) Received: from linux3247.grserver.gr (linux3247.grserver.gr [213.158.90.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by relay12.grserver.gr (Proxmox) with ESMTPS id 0C5A5BDC7E for ; Thu, 16 Oct 2025 15:28:25 +0300 (EEST) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) by linux3247.grserver.gr (Postfix) with ESMTPSA id 606F91FFC15 for ; Thu, 16 Oct 2025 15:28:24 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=antheas.dev; s=default; t=1760617704; bh=izcuUsiglIFkfY1fDcw4kBwfuEBiw3xCPP4RTqn4tek=; h=Received:From:Subject:To; b=f6BYCf8WNKMvuHPmyDojSI+V6FZkCOTm2ua+GDOX9fBAZ+efrFWdLCaVc+frQeOeL O5qZ3+8kBMpzaZqrOG6tRLMGyQ8UlrNVVWsb4/kg/LuTIG+kxqiH50Lu20wsQV7no/ 6KYyX7peUKtIyVabtsE/8qvkZaxGIQPsx9ATVfpQUVipgC/WifK6C/66j2jUKJKtkE 3i/zWh/q34Ptt3Vu7eVLNj+d7Ti0n9PD3vAFC7+ECSl1u8xPJVL2dSdtRm0VyAddro kr01pQhmz62nEYZk+cH/HYKseYH3GHWUrMRK5emSyGSy57esS/o0gsCnJH6ICauQMd kElnEJOFa8+GQ== Authentication-Results: linux3247.grserver.gr; spf=pass (sender IP is 209.85.208.172) smtp.mailfrom=lkml@antheas.dev smtp.helo=mail-lj1-f172.google.com Received-SPF: pass (linux3247.grserver.gr: connection is authenticated) Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-373a1ab2081so6377921fa.3 for ; Thu, 16 Oct 2025 05:28:24 -0700 (PDT) X-Gm-Message-State: AOJu0Yx4DRQZkFePlVoVFBziOXvlJ0qRauqCDL/s5hIOONLCoeJMLcLK qRE83NRiEWHXurLQQc7AeOhODhqmZN5J+tvx2nMlr7PGFW9uahXaM+cvd0v04VUgRgxZLrFO9OD Nhgi6i5E0QaauXuHBVLW1zNQo4o5ZcR0= X-Google-Smtp-Source: AGHT+IEvoa3TOyjqGeN5FQJBL4etgFpgPZIu8g83zKyg/JgIqkHkvaNu9oVrnL2eNM7j9yh418qGlgNQz8PX9uspRBQ= X-Received: by 2002:a05:651c:501:b0:337:e5fc:d2d with SMTP id 38308e7fff4ca-37797a0fb97mr26381fa.24.1760617703703; Thu, 16 Oct 2025 05:28:23 -0700 (PDT) Precedence: bulk X-Mailing-List: platform-driver-x86@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251013201535.6737-1-lkml@antheas.dev> <160c3adf-9333-4486-ba4c-d3359ea73337@gmail.com> In-Reply-To: From: Antheas Kapenekakis Date: Thu, 16 Oct 2025 14:28:12 +0200 X-Gmail-Original-Message-ID: X-Gm-Features: AS18NWBK5AFob6ufMe1ZI-OUA7mVrHdqUDcgo4w8SuAfJPBT17iJGVSpqQfTPKc Message-ID: Subject: Re: [PATCH v6 0/7] HID: asus: Fix ASUS ROG Laptop's Keyboard backlight handling To: Denis Benato Cc: platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Corentin Chary , "Luke D . Jones" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= Content-Type: text/plain; charset="UTF-8" X-PPP-Message-ID: <176061770459.3220639.327203989042930223@linux3247.grserver.gr> X-PPP-Vhost: antheas.dev X-Virus-Scanned: clamav-milter 1.4.3 at linux3247.grserver.gr X-Virus-Status: Clean On Thu, 16 Oct 2025 at 14:19, Denis Benato wrote: > > > On 10/16/25 14:14, Antheas Kapenekakis wrote: > > On Thu, 16 Oct 2025 at 13:57, Denis Benato wrote: > >> > >> On 10/13/25 22:15, Antheas Kapenekakis wrote: > >>> This is a two part series which does the following: > >>> - Clean-up init sequence > >>> - Unify backlight handling to happen under asus-wmi so that all Aura > >>> devices have synced brightness controls and the backlight button works > >>> properly when it is on a USB laptop keyboard instead of one w/ WMI. > >>> > >>> For more context, see cover letter of V1. Since V5, I removed some patches > >>> to make this easier to merge. > >>> > >>> All comments with these patches had been addressed since V4. > >> I have loaded this patchset for users of asus-linux project to try out. > >> > >> One of them opened a bug report about a kernel bug that happens > >> consistently when closing the lid of his laptop [1]. > >> > >> He also sent another piece of kernel log, but didn't specify anything more > >> about this [2]. > >> > >> [1] https://pastebin.com/akZx1w10 > >> [2] https://pastebin.com/sKdczPgf > > Can you provide a link to the bug report? [2] seems unrelated. > The log in [2] was posted without additional context in the same > discord message as [1]. Link me the kernel sources. Is it linux-g14 in the AUR? > I think I will tell the user to open a proper bug report because > I do agree on the fact that it's looking unrelated. > > As for [1], it looks like a trace that stems from a sysfs write to > > brightness stemming from userspace that follows the same chain it > > would on a stock kernel and times out. Is it present on a stock > > kernel? > I have asked more details to the user. The user is not online ATM > so I will get to you with more details when I can. > > Ilpo should know more about this, could the spinlock be interfering? > > My testing on devices that have WMI led controls is a bit limited > > unfortunately. However, most of our asus users have been happy with > > this series for around half a year now. > Unless they have looked to kernel logs they won't be able to tell > since apparently there are no visible consequences. > > Antheas > > > >>> --- > >>> V5: https://lore.kernel.org/all/20250325184601.10990-1-lkml@antheas.dev/ > >>> V4: https://lore.kernel.org/lkml/20250324210151.6042-1-lkml@antheas.dev/ > >>> V3: https://lore.kernel.org/lkml/20250322102804.418000-1-lkml@antheas.dev/ > >>> V2: https://lore.kernel.org/all/20250320220924.5023-1-lkml@antheas.dev/ > >>> V1: https://lore.kernel.org/all/20250319191320.10092-1-lkml@antheas.dev/ > >>> > >>> Changes since V5: > >>> - It's been a long time > >>> - Remove addition of RGB as that had some comments I need to work on > >>> - Remove folio patch (already merged) > >>> - Remove legacy fix patch 11 from V4. There is a small chance that > >>> without this patch, some old NKEY keyboards might not respond to > >>> RGB commands according to Luke, but the kernel driver does not do > >>> RGB currently. The 0x5d init is done by Armoury crate software in > >>> Windows. If an issue is found, we can re-add it or just remove patches > >>> 1/2 before merging. However, init could use the cleanup. > >>> > >>> Changes since V4: > >>> - Fix KConfig (reported by kernel robot) > >>> - Fix Ilpo's nits, if I missed anything lmk > >>> > >>> Changes since V3: > >>> - Add initializer for 0x5d for old NKEY keyboards until it is verified > >>> that it is not needed for their media keys to function. > >>> - Cover init in asus-wmi with spinlock as per Hans > >>> - If asus-wmi registers WMI handler with brightness, init the brightness > >>> in USB Asus keyboards, per Hans. > >>> - Change hid handler name to asus-UNIQ:rgb:peripheral to match led class > >>> - Fix oops when unregistering asus-wmi by moving unregister outside of > >>> the spin lock (but after the asus reference is set to null) > >>> > >>> Changes since V2: > >>> - Check lazy init succeds in asus-wmi before setting register variable > >>> - make explicit check in asus_hid_register_listener for listener existing > >>> to avoid re-init > >>> - rename asus_brt to asus_hid in most places and harmonize everything > >>> - switch to a spinlock instead of a mutex to avoid kernel ooops > >>> - fixup hid device quirks to avoid multiple RGB devices while still exposing > >>> all input vendor devices. This includes moving rgb init to probe > >>> instead of the input_configured callbacks. > >>> - Remove fan key (during retest it appears to be 0xae that is already > >>> supported by hid-asus) > >>> - Never unregister asus::kbd_backlight while asus-wmi is active, as that > >>> - removes fds from userspace and breaks backlight functionality. All > >>> - current mainline drivers do not support backlight hotplugging, so most > >>> userspace software (e.g., KDE, UPower) is built with that assumption. > >>> For the Ally, since it disconnects its controller during sleep, this > >>> caused the backlight slider to not work in KDE. > >>> > >>> Changes since V1: > >>> - Add basic RGB support on hid-asus, (Z13/Ally) tested in KDE/Z13 > >>> - Fix ifdef else having an invalid signature (reported by kernel robot) > >>> - Restore input arguments to init and keyboard function so they can > >>> be re-used for RGB controls. > >>> - Remove Z13 delay (it did not work to fix the touchpad) and replace it > >>> with a HID_GROUP_GENERIC quirk to allow hid-multitouch to load. Squash > >>> keyboard rename into it. > >>> - Unregister brightness listener before removing work queue to avoid > >>> a race condition causing corruption > >>> - Remove spurious mutex unlock in asus_brt_event > >>> - Place mutex lock in kbd_led_set after LED_UNREGISTERING check to avoid > >>> relocking the mutex and causing a deadlock when unregistering leds > >>> - Add extra check during unregistering to avoid calling unregister when > >>> no led device is registered. > >>> - Temporarily HID_QUIRK_INPUT_PER_APP from the ROG endpoint as it causes > >>> the driver to create 4 RGB handlers per device. I also suspect some > >>> extra events sneak through (KDE had the @@@@@@). > >>> > >>> Antheas Kapenekakis (7): > >>> HID: asus: refactor init sequence per spec > >>> HID: asus: prevent binding to all HID devices on ROG > >>> platform/x86: asus-wmi: Add support for multiple kbd RGB handlers > >>> HID: asus: listen to the asus-wmi brightness device instead of > >>> creating one > >>> platform/x86: asus-wmi: remove unused keyboard backlight quirk > >>> platform/x86: asus-wmi: add keyboard brightness event handler > >>> HID: asus: add support for the asus-wmi brightness handler > >>> > >>> drivers/hid/hid-asus.c | 235 +++++++++++---------- > >>> drivers/platform/x86/asus-wmi.c | 157 ++++++++++++-- > >>> include/linux/platform_data/x86/asus-wmi.h | 69 +++--- > >>> 3 files changed, 291 insertions(+), 170 deletions(-) > >>> > >>> > >>> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787 >