* [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode
@ 2018-04-20 21:32 Antonio Rosario Intilisano
0 siblings, 0 replies; 3+ messages in thread
From: Antonio Rosario Intilisano @ 2018-04-20 21:32 UTC (permalink / raw)
To: dvhart
Cc: andy, platform-driver-x86, linux-kernel, locutusofborg,
Antonio Rosario Intilisano, Chris Chiu, Daniel Drake,
Andy Shevchenko
Now that we have informed the firmware that the Power Button driver is
active, laptops such as the Acer Swift 3 will generate
a WMI key event with code 0x87 when the power button key is
pressed.
Add this keycode to the table so that it is converted to an appropriate
input event.
Signed-off-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
Acked-by: Gianfranco Costamagna <locutusofborg@debian.org>
Cc: Chris Chiu <chiu@endlessm.com>
Cc: Daniel Drake <drake@endlessm.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/platform/x86/acer-wmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 1be71f956d5c..8952173dd380 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = { {KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },
{KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
{KE_KEY, 0x86, {KEY_WLAN} },
+ {KE_KEY, 0x87, {KEY_POWER} },
{KE_END, 0}
};
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode
@ 2018-04-27 21:50 Antonio Rosario Intilisano
2018-05-07 14:08 ` Andy Shevchenko
0 siblings, 1 reply; 3+ messages in thread
From: Antonio Rosario Intilisano @ 2018-04-27 21:50 UTC (permalink / raw)
To: dvhart
Cc: andy, platform-driver-x86, linux-kernel, locutusofborg,
Antonio Rosario Intilisano, Chris Chiu, Daniel Drake,
Andy Shevchenko
Now that we have informed the firmware that the Power Button driver is
active, laptops such as the Acer Swift 3 will generate
a WMI key event with code 0x87 when the power button key is
pressed.
Add this keycode to the table so that it is converted to an appropriate
input event.
Signed-off-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
Acked-by: Gianfranco Costamagna <locutusofborg@debian.org>
Tested-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
Cc: Chris Chiu <chiu@endlessm.com>
Cc: Daniel Drake <drake@endlessm.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/platform/x86/acer-wmi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index 1be71f956d5c..8952173dd380 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = { {KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },
{KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
{KE_KEY, 0x86, {KEY_WLAN} },
+ {KE_KEY, 0x87, {KEY_POWER} },
{KE_END, 0}
};
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode
2018-04-27 21:50 [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode Antonio Rosario Intilisano
@ 2018-05-07 14:08 ` Andy Shevchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2018-05-07 14:08 UTC (permalink / raw)
To: Antonio Rosario Intilisano
Cc: Darren Hart, Andy Shevchenko, Platform Driver,
Linux Kernel Mailing List, Gianfranco Costamagna, Chris Chiu,
Daniel Drake, Andy Shevchenko
On Sat, Apr 28, 2018 at 12:50 AM, Antonio Rosario Intilisano
<antonio.intilisano@gmail.com> wrote:
> Now that we have informed the firmware that the Power Button driver is
> active, laptops such as the Acer Swift 3 will generate
> a WMI key event with code 0x87 when the power button key is
> pressed.
>
> Add this keycode to the table so that it is converted to an appropriate
> input event.
I pushed it to my review and testing queue, thanks!
Though, see below.
>
> Signed-off-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
> Acked-by: Gianfranco Costamagna <locutusofborg@debian.org>
> Tested-by: Antonio Rosario Intilisano <antonio.intilisano@gmail.com>
> Cc: Chris Chiu <chiu@endlessm.com>
> Cc: Daniel Drake <drake@endlessm.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> ---
> drivers/platform/x86/acer-wmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index 1be71f956d5c..8952173dd380 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -129,6 +129,7 @@ static const struct key_entry acer_wmi_keymap[] __initconst = { {KE_IGNORE, 0x83, {KEY_TOUCHPAD_TOGGLE} },
This is malformed patch. It states 6 lines for context, though only 4
provided. Please, fix your tools.
> {KE_KEY, 0x85, {KEY_TOUCHPAD_TOGGLE} },
> {KE_KEY, 0x86, {KEY_WLAN} },
> + {KE_KEY, 0x87, {KEY_POWER} },
> {KE_END, 0}
> };
>
> --
> 2.15.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-07 14:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-27 21:50 [PATCH] platform/x86: acer-wmi: add another KEY_POWER keycode Antonio Rosario Intilisano
2018-05-07 14:08 ` Andy Shevchenko
-- strict thread matches above, loose matches on Subject: below --
2018-04-20 21:32 Antonio Rosario Intilisano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).