From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hansg@kernel.org>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>,
platform-driver-x86@vger.kernel.org,
"Hans de Goede" <hdegoede@redhat.com>
Subject: Re: [PATCH 2/2] platform/x86: x86-android-tablets: Add support for Acer A1-840 tablet
Date: Mon, 1 Sep 2025 12:13:10 +0300 [thread overview]
Message-ID: <CAHp75VeJutOpvhh5-97RS73GMrJB5HyNggLtVjw9d3RM8Y_WEQ@mail.gmail.com> (raw)
In-Reply-To: <20250831105315.15349-2-hansg@kernel.org>
On Sun, Aug 31, 2025 at 1:53 PM Hans de Goede <hansg@kernel.org> wrote:
>
> From: Hans de Goede <hdegoede@redhat.com>
>
> Add support for the Acer Iconia One 8 A1-840 (non FHD version) tablet.
>
> This tablet has the usual issues for tablets shipped with Android as
> factory OS. The DSDT is broken in various ways, so i2c_clients for
> various devices as well as the INT3496 platform-device for OTG extcon
> handling need to be instantiated manually by x86-android-tablets.
>
> This table is special in that it is the first time a Bay Trail device
> has been found to use the Dollar Cove TI PMIC and the first time that
> the PMIC's Coulomb Counter is used as fuel-gauge.
>
> So far this PMIC has only been used together with Cherry Trail SoCs
> and always in combination with a separate full-featured fuel-gauge IC.
Indeed, an interesting combination. Perhaps due to some cost savings on the BoM.
...
Both patches LGTM, but I have a question. Do you plan to move to
software nodes for the GPIOs, so Dmitry will have less work to convert
them? If so, perhaps it should be a patch in the middle to convert the
new file to use swnode, or the precursor that converts the whole
driver beforehand. What do you think?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-09-01 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-31 10:53 [PATCH 1/2] platform/x86: x86-android-tablets: Move Acer info to its own file Hans de Goede
2025-08-31 10:53 ` [PATCH 2/2] platform/x86: x86-android-tablets: Add support for Acer A1-840 tablet Hans de Goede
2025-09-01 9:13 ` Andy Shevchenko [this message]
2025-09-10 11:00 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VeJutOpvhh5-97RS73GMrJB5HyNggLtVjw9d3RM8Y_WEQ@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=hansg@kernel.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).