From: "Kurt Borja" <kuurtb@gmail.com>
To: "Armin Wolf" <W_Armin@gmx.de>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: <platform-driver-x86@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <Dell.Client.Kernel@dell.com>
Subject: Re: [PATCH RFC v2 1/2] platform/x86: wmi: Add wmidev_get_acpi_device_uid()
Date: Wed, 12 Mar 2025 00:27:06 -0500 [thread overview]
Message-ID: <D8E1ENUHLP10.2BBUD2EP7MRGZ@gmail.com> (raw)
In-Reply-To: <9c172560-65ee-4468-93f7-ea5c11fe033f@gmx.de>
On Tue Mar 11, 2025 at 2:21 PM -05, Armin Wolf wrote:
> Am 09.03.25 um 06:13 schrieb Kurt Borja:
>
>> Add a non-deprecated version of wmi_get_acpi_device_uid().
>
> Hi,
>
> i can understand you motivation behind this patch, but this is IMHO the wrong approach.
> Nothing guarantees us that a given ACPI _UID value will reliably signal the presence of
> WMI methods now or in the future. Because of this i am against this patch.
Yes, in the end it is a leap of faith.
I think that it's not very risky as AFAIK AWCC didn't even exist when
devices used the legacy RGB interface. Also as Mario mentioned, only a
handful of devices supported the legacy interface, compared to the large
amount of systems with the AWCC one.
But of course, there is always a possibility of regressions for some
unknown edge case.
>
> The correct way would be to use the BMOF data to check for missing WMI methods. I did
> some work on that which i will announce soon.
Anyways, this is very cool and indeed the correct approach. Hopefully
I'll be able to help a bit, as I spent some time studying Pali's
decoder.
--
~ Kurt
next prev parent reply other threads:[~2025-03-12 5:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-09 5:13 [PATCH RFC v2 0/2] platform/x86: alienware-wmi-wmax: Extend support to many devices Kurt Borja
2025-03-09 5:13 ` [PATCH RFC v2 1/2] platform/x86: wmi: Add wmidev_get_acpi_device_uid() Kurt Borja
2025-03-11 19:21 ` Armin Wolf
2025-03-12 5:27 ` Kurt Borja [this message]
2025-03-09 5:13 ` [PATCH RFC v2 2/2] platform/x86: alienware-wmi-wmax: Check for AWCC support using _UID Kurt Borja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8E1ENUHLP10.2BBUD2EP7MRGZ@gmail.com \
--to=kuurtb@gmail.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=W_Armin@gmx.de \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox