X86 platform drivers
 help / color / mirror / Atom feed
From: "Kurt Borja" <kuurtb@gmail.com>
To: "L Lawliet" <kmtechnical2006@gmail.com>,
	<platform-driver-x86@vger.kernel.org>
Cc: <kuurtb@gmail.com>
Subject: Re: [PATCH] alieneware-wmi-wmax: Add AWCC support to Dell G15 5530
Date: Tue, 23 Sep 2025 09:43:14 -0500	[thread overview]
Message-ID: <DD09CP8SI4S3.D0SYL9FM7MR2@gmail.com> (raw)
In-Reply-To: <CAE_EmHsRBLJauuYJinTaf=Q6MzexHWti2SWeX8DWPmF6FN-aNA@mail.gmail.com>

Hi tr1x_em,

Thank you for your patch!

I believe you patched my personal development tree. Upstream patches
should be made on top of the pdx86 Linux tree:

	[1] https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git

This should be Cc'd to subsystem maintainers too. You can get the full
list of maintainers with the get_maintainer.pl script (which is also
found in the tree above):

$ ./scripts/get_maintainer.pl drivers/platform/x86/dell/alienware-wmi-wmax.c

There is also a few issues bellow.

On Tue Sep 23, 2025 at 8:03 AM -05, L Lawliet wrote:
> From 1dad6e971a889c7936d1a54ab38f146bd23ebbf3 Mon Sep 17 00:00:00 2001
> From: tr1x_em <admin@trix.is-a.dev>
> Date: Tue, 23 Sep 2025 18:24:58 +0530
> Subject: [PATCH] alieneware-wmi-wmax: Add AWCC support to Dell G15 5530
>

Add a commit description too (even if it's a little redundant).

> Signed-off-by: tr1x_em <admin@trix.is-a.dev>

Patches can only be signed off with a known identity (which is usually
your real name).

> ---
>  alienware-wmi-wmax.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/alienware-wmi-wmax.c b/alienware-wmi-wmax.c
> index fd550c8..e7ba590 100644
> --- a/alienware-wmi-wmax.c
> +++ b/alienware-wmi-wmax.c

Again, diffs should be taken from the root of the Linux tree.

> @@ -209,6 +209,15 @@ static const struct dmi_system_id
> awcc_dmi_table[] __initconst = {
>          },
>          .driver_data = &g_series_quirks,
>      },
> +    {
> +        .ident = "Dell Inc. G15 5530",
> +        .matches =
> +            {
> +                DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +                DMI_MATCH(DMI_PRODUCT_NAME, "G15 5530"),
> +            },
> +        .driver_data = &g_series_quirks,
> +    },
>      {
>          .ident = "Dell Inc. G16 7630",
>          .matches = {

I believe your editor or email client messed up the formatting. Kernel
source files use tabs instead of spaces.

Please, check the "Submitting patches" guide if you have doubts:

	[2] https://docs.kernel.org/process/submitting-patches.html


-- 
 ~ Kurt


  reply	other threads:[~2025-09-23 14:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-23 13:03 [PATCH] alieneware-wmi-wmax: Add AWCC support to Dell G15 5530 L Lawliet
2025-09-23 14:43 ` Kurt Borja [this message]
2025-09-24  4:31   ` L Lawliet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DD09CP8SI4S3.D0SYL9FM7MR2@gmail.com \
    --to=kuurtb@gmail.com \
    --cc=kmtechnical2006@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox