platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Kurt Borja" <kuurtb@gmail.com>
To: "tr1x_em" <admin@trix.is-a.dev>, <platform-driver-x86@vger.kernel.org>
Cc: <Dell.Client.Kernel@dell.com>, <kuurtb@gmail.com>
Subject: Re: [PATCH v2 1/1] alienware-wmi-wmax:Add AWCC support to Dell G15 5530
Date: Wed, 24 Sep 2025 13:57:28 -0500	[thread overview]
Message-ID: <DD19DW23BFFN.3JNH1C2UEZFED@gmail.com> (raw)
In-Reply-To: <20250924062721.209621-2-admin@trix.is-a.dev>

Hi Saumya,

I overlooked a couple of things.

Please, add "platform/x86: " before "alienware-wmi-wmax" in the subject
and leave a space after each ":".

On Wed Sep 24, 2025 at 1:27 AM -05, tr1x_em wrote:
> Makes alienware-wmi load on G15 5530 by default Tested by me

Drop "Tested by me".

>

Here, just before your SoB without empty lines in between, add:

Cc: stable@vger.kernel.org

So it can be included in stable releases.

> Signed-off-by: Saumya <admin@trix.is-a.dev>
> ---
>  drivers/platform/x86/dell/alienware-wmi-wmax.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/drivers/platform/x86/dell/alienware-wmi-wmax.c b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> index 31f9643a6..3b25a8283 100644
> --- a/drivers/platform/x86/dell/alienware-wmi-wmax.c
> +++ b/drivers/platform/x86/dell/alienware-wmi-wmax.c
> @@ -209,6 +209,14 @@ static const struct dmi_system_id awcc_dmi_table[] __initconst = {
>  		},
>  		.driver_data = &g_series_quirks,
>  	},
> +	{
> +		.ident = "Dell Inc. G15 5530",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Dell G15 5530"),
> +		},
> +		.driver_data = &g_series_quirks,
> +	},
>  	{
>  		.ident = "Dell Inc. G16 7630",
>  		.matches = {
> --
> 2.51.0

Also, please Cc this to subsystem maintainers too:

 - Hans de Goede <hansg@kernel.org>
 - Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>


-- 
 ~ Kurt


      reply	other threads:[~2025-09-24 18:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-24  6:27 [PATCH v2 0/1] alienware-wmi-wmax: Add AWCC support to Dell G15 5530 tr1x_em
2025-09-24  6:27 ` [PATCH v2 1/1] alienware-wmi-wmax:Add " tr1x_em
2025-09-24 18:57   ` Kurt Borja [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DD19DW23BFFN.3JNH1C2UEZFED@gmail.com \
    --to=kuurtb@gmail.com \
    --cc=Dell.Client.Kernel@dell.com \
    --cc=admin@trix.is-a.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).