From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA04DC77B75 for ; Wed, 3 May 2023 21:22:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229632AbjECVW2 (ORCPT ); Wed, 3 May 2023 17:22:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbjECVW1 (ORCPT ); Wed, 3 May 2023 17:22:27 -0400 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 980756A61; Wed, 3 May 2023 14:22:26 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 1EEFA5C01C1; Wed, 3 May 2023 17:22:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 03 May 2023 17:22:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ljones.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1683148944; x=1683235344; bh=vkO0ztCMvjXTnReErYaR/lu+lP84Bh14IHf bhLWpzJM=; b=wX2hu0Y20uP/wj/9ULiM3v7p0X14AfSbO7e8mM1u9q0G2Z4RusS xyT5EC9KwqUemVe/Tfh4S+K73HrpLSCXtW+dZgJ16FuH2zLXRj5Tnl6Z4cFhZpZ4 8UH0hjKLpP02oJVl9Qk8dLYEDZOUfCvMX+Mi5tG+MtUbB0qEnubuGC2JnXCIRrZw j0J7zy8Y5Py1SoUQvemAOWRB+Ol6/bZagxFftUhLwjz8b73a5vK43ff8bqNPzhhj 873Z/2Hu0IV9FWhY/ZOnWqf5mjRcLrdJOmFJmcJ5Oyr5Afv2yT6bgwY1IuPZrAhz BRQcyGYg1IQbwctCmUUguyDgkyh2A33yYLQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1683148944; x=1683235344; bh=vkO0ztCMvjXTnReErYaR/lu+lP84Bh14IHf bhLWpzJM=; b=AC5Yr/wogC98ll8sPwixWfPXgPff/DxWgC1ecpR7RI9+e6gXs3f uIGE9Bs0Y0PlZK7fWR5OCN7BUv+szI/39lONnSKvKKSU1zsbFu3S5cIfZupJlB1y o+/JALbVMxPr3dYylHH3iXxvPkLZ6oT+sQMUnALdKAQhoJG9vJ/tOR6HyZmCWE/A oA/kUqT37THLkxg84oj1U+QH/u0OLVTPlEqFBxp+lPKkHY1ZbtA62yWjKnItRrd/ uFW+8gLqYnk79uOX/j5fd9tlvEQfRBhta4hZ61Vjh2ew6CRWOHofChEB1yRLDJfp ufAosD0fwDLK+qwrHGVkF2VQ5Gjv/46RNCQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedvkedgudehjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhuffvvefkjghfofggtgfgse htqhertdertdhsnecuhfhrohhmpefnuhhkvgculfhonhgvshcuoehluhhkvgeslhhjohhn vghsrdguvghvqeenucggtffrrghtthgvrhhnpeffleejheffgfduveeihffhkeelheeuve dugfdtvddtvdeffedukeevteekuedugfenucffohhmrghinheprghsuhhsrdgtohhmnecu vehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhhukhgvse hljhhonhgvshdruggvvh X-ME-Proxy: Feedback-ID: i5ec1447f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 May 2023 17:22:16 -0400 (EDT) Date: Thu, 04 May 2023 09:22:03 +1200 From: Luke Jones Subject: Re: [PATCH] platform/x86: asus-wmi: add support for ASUS screenpad To: =?iso-8859-2?q?Barnab=E1s_P=F5cze?= Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, acpi4asus-user@lists.sourceforge.net, hdegoede@redhat.com, corentin.chary@gmail.com, markgross@kernel.org, jdelvare@suse.com, linux@roeck-us.net Message-Id: In-Reply-To: <_BfjSVwlhmByGevAd1Yo_jhipUa3r6y5HHSi34xdeaYqelyPe1PRnOEru21Yw76x0spJwAAs3jr0MJ0f_jUc8QY75Q1J1ovT5QPvm0p2WhY=@protonmail.com> References: <20230503040207.257406-1-luke@ljones.dev> <_BfjSVwlhmByGevAd1Yo_jhipUa3r6y5HHSi34xdeaYqelyPe1PRnOEru21Yw76x0spJwAAs3jr0MJ0f_jUc8QY75Q1J1ovT5QPvm0p2WhY=@protonmail.com> X-Mailer: geary/43.0 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org On Wed, May 3 2023 at 17:46:53 +0000, Barnab=E1s P=F5cze=20 wrote: > Hi >=20 >=20 > 2023. m=E1jus 3., szerda 6:02 keltez=E9ssel, Luke D. Jones=20 > =EDrta: >=20 >> Add support for the WMI methods used to turn off and adjust the >> brightness of the secondary "screenpad" device found on some=20 >> high-end >> ASUS laptops like the GX650P series and others. >=20 > Is it this one: https://www.asus.com/content/rog-screenpad-plus/ ? > Or is the "plus" version something different? >=20 > If it's a "proper" screen, wouldn't it be better to add support for it > in the respective subsystems? E.g. why not register a backlight=20 > device? I think it is similar yes, likely the same thing. Adding as a proper backlight is what I wanted to do but at first blush=20 I wasn't sure. Looking at include/linux/backlight.h + some examples it looks clear=20 now. I'll try to work up a revised patch and get it tested by the folks with the actual=20 laptop. My only possible issue would be how to handle the on/off part? Cheers, Luke.