From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <markgross@kernel.org>, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 1/9] platform/x86: x86-android-tablets: Move into its own subdir
Date: Tue, 21 Feb 2023 11:41:49 +0200 [thread overview]
Message-ID: <Y/SR3XV5urDF1aKj@smile.fi.intel.com> (raw)
In-Reply-To: <20230220221212.196009-2-hdegoede@redhat.com>
On Mon, Feb 20, 2023 at 11:12:04PM +0100, Hans de Goede wrote:
> Move the x86-android-tablets code into its own subdir, this is
> a preparation patch for splitting the somewhat large file into
> multiple smaller files.
I'm in favour of the move, but some comments here and there...
...
> +# SPDX-License-Identifier: GPL-2.0+
Perhaps switch to "-or-later"?
...
> +config X86_ANDROID_TABLETS
> + tristate "X86 Android tablet support"
> + depends on I2C && SPI && SERIAL_DEV_BUS && ACPI && EFI && GPIOLIB
I'm wondering if we can increase (compile) test coverage by splitting and
refactoring like
depends on ACPI && EFI
depends on (I2C && SPI && SERIAL_DEV_BUS && GPIOLIB) || COMPILE_TEST
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-21 9:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 22:12 [PATCH 0/9] platform/x86: x86-android-tablets: Split into multiple files + gpio_keys rework Hans de Goede
2023-02-20 22:12 ` [PATCH 1/9] platform/x86: x86-android-tablets: Move into its own subdir Hans de Goede
2023-02-21 9:41 ` Andy Shevchenko [this message]
2023-02-20 22:12 ` [PATCH 2/9] platform/x86: x86-android-tablets: Move core code into new core.c file Hans de Goede
2023-02-21 9:55 ` Andy Shevchenko
2023-02-20 22:12 ` [PATCH 3/9] platform/x86: x86-android-tablets: Move DMI match table into its own dmi.c file Hans de Goede
2023-02-21 9:57 ` Andy Shevchenko
2023-02-20 22:12 ` [PATCH 4/9] platform/x86: x86-android-tablets: Move shared power-supply fw-nodes to a separate file Hans de Goede
2023-02-21 9:58 ` Andy Shevchenko
2023-02-21 9:59 ` Andy Shevchenko
2023-02-20 22:12 ` [PATCH 5/9] platform/x86: x86-android-tablets: Move Asus tablets to their own file Hans de Goede
2023-02-20 22:12 ` [PATCH 6/9] platform/x86: x86-android-tablets: Move Lenovo " Hans de Goede
2023-02-20 22:12 ` [PATCH 7/9] platform/x86: x86-android-tablets: Move remaining tablets to other.c Hans de Goede
2023-02-20 22:12 ` [PATCH 8/9] platform/x86: x86-android-tablets: Add gpio_keys support to x86_android_tablet_init() Hans de Goede
2023-02-21 10:04 ` Andy Shevchenko
2023-02-20 22:12 ` [PATCH 9/9] platform/x86: x86-android-tablets: Add support for the Dolby button on Peaq C1010 Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/SR3XV5urDF1aKj@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox