From: Greg KH <gregkh@linuxfoundation.org>
To: Mark Pearson <mpearson-lenovo@squebb.ca>
Cc: hdegoede@redhat.com, markgross@kernel.org,
mario.limonciello@amd.com, platform-driver-x86@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] platform/x86: thinkpad_acpi: Fix profile modes on Intel platforms
Date: Tue, 24 Jan 2023 17:18:39 +0100 [thread overview]
Message-ID: <Y9AE3wuhbNYRDp6w@kroah.com> (raw)
In-Reply-To: <20230124153623.145188-1-mpearson-lenovo@squebb.ca>
On Tue, Jan 24, 2023 at 10:36:23AM -0500, Mark Pearson wrote:
> My last commit to fix profile mode displays on AMD platforms caused
> an issue on Intel platforms - sorry!
>
> In it I was reading the current functional mode (MMC, PSC, AMT) from
> the BIOS but didn't account for the fact that on some of our Intel
> platforms I use a different API which returns just the profile and not
> the functional mode.
>
> This commit fixes it so that on Intel platforms it knows the functional
> mode is always MMC.
>
> I also fixed a potential problem that a platform may try to set the mode
> for both MMC and PSC - which was incorrect.
>
> Tested on X1 Carbon 9 (Intel) and Z13 (AMD).
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=216963
> Fixes: fde5f74ccfc7 ("platform/x86: thinkpad_acpi: Fix profile mode display in AMT mode")
>
> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2023-01-24 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 15:36 [PATCH] platform/x86: thinkpad_acpi: Fix profile modes on Intel platforms Mark Pearson
2023-01-24 15:42 ` Limonciello, Mario
2023-01-24 16:18 ` Greg KH [this message]
2023-01-25 11:49 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9AE3wuhbNYRDp6w@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=mario.limonciello@amd.com \
--cc=markgross@kernel.org \
--cc=mpearson-lenovo@squebb.ca \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox