From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65842C4338F for ; Fri, 6 Aug 2021 09:04:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36D1961159 for ; Fri, 6 Aug 2021 09:04:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243869AbhHFJEi (ORCPT ); Fri, 6 Aug 2021 05:04:38 -0400 Received: from mga11.intel.com ([192.55.52.93]:10069 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243794AbhHFJEi (ORCPT ); Fri, 6 Aug 2021 05:04:38 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10067"; a="211233378" X-IronPort-AV: E=Sophos;i="5.84,300,1620716400"; d="scan'208";a="211233378" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2021 02:04:21 -0700 X-IronPort-AV: E=Sophos;i="5.84,300,1620716400"; d="scan'208";a="672125541" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Aug 2021 02:04:19 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1mBvm1-005lgs-Rb; Fri, 06 Aug 2021 12:04:13 +0300 Date: Fri, 6 Aug 2021 12:04:13 +0300 From: Andy Shevchenko To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Hans de Goede , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Gross Subject: Re: [RFT, PATCH v1 1/1] platform/x86: dell-smo8800: Convert to be a platform driver Message-ID: References: <20210803194039.35083-1-andriy.shevchenko@linux.intel.com> <20210805192221.s7uoi5gh6zzkqinh@pali> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210805192221.s7uoi5gh6zzkqinh@pali> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org On Thu, Aug 05, 2021 at 09:22:21PM +0200, Pali Rohár wrote: > On Tuesday 03 August 2021 22:40:39 Andy Shevchenko wrote: > > ACPI core in conjunction with platform driver core provides > > an infrastructure to enumerate ACPI devices. Use it in order > > to remove a lot of boilerplate code. > > > > Signed-off-by: Andy Shevchenko > > Tested on Dell Latitude E6440. After applying this patch /dev/freefall > device is created and can be opened (for waiting for disk fall). Also > interrupt is registered in /proc/interrupts file: > > 23: 0 0 0 0 IR-IO-APIC 23-edge smo8800 > > But I have not done real hard disk fall on this machine :-) so I guess > it would work as before applying this patch. At least the change doesn't touch any functional parts except device driver enumeration. > Reviewed-by: Pali Rohár > Tested-by: Pali Rohár Thank you! -- With Best Regards, Andy Shevchenko