From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Arnd Bergmann" <arnd@arndb.de>,
"Eric Piel" <eric.piel@tremplin-utc.net>,
"Mark Gross" <mgross@linux.intel.com>,
"Mark Brown" <broonie@kernel.org>,
kernel@pengutronix.de, linux-spi@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 12/20] misc: lis3lv02d: Make lis3lv02d_remove_fs() return void
Date: Wed, 13 Oct 2021 11:01:53 +0200 [thread overview]
Message-ID: <YWaggVCzL/CoVLa6@kroah.com> (raw)
In-Reply-To: <bc739810-abb4-d7bc-e901-227b43bc5a71@redhat.com>
On Tue, Oct 12, 2021 at 05:54:46PM +0200, Hans de Goede wrote:
> Hi,
>
> On 10/12/21 5:39 PM, Uwe Kleine-König wrote:
> > Up to now lis3lv02d_remove_fs() returns zero unconditionally. Make it return
> > void instead which makes it easier to see in the callers that there is
> > no error to handle.
> >
> > Also the return value of i2c and spi remove callbacks is ignored anyway.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Thanks, patch looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> Also please consider this as my ack for merging the
> drivers/platform/x86/ part of this through whatever
> tree is convenient.
Thanks, I'll take it!
greg k-h
prev parent reply other threads:[~2021-10-13 9:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 15:39 [PATCH v2 00/20] Make some spi device drivers return zero in .remove() Uwe Kleine-König
2021-10-12 15:39 ` [PATCH v2 12/20] misc: lis3lv02d: Make lis3lv02d_remove_fs() return void Uwe Kleine-König
2021-10-12 15:54 ` Hans de Goede
2021-10-13 9:01 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWaggVCzL/CoVLa6@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=eric.piel@tremplin-utc.net \
--cc=hdegoede@redhat.com \
--cc=kernel@pengutronix.de \
--cc=linux-spi@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox