From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2800EC433F5 for ; Fri, 25 Feb 2022 16:36:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243078AbiBYQgj (ORCPT ); Fri, 25 Feb 2022 11:36:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243069AbiBYQgj (ORCPT ); Fri, 25 Feb 2022 11:36:39 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84A2022310F; Fri, 25 Feb 2022 08:36:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645806966; x=1677342966; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IZnoVmPnir54K979MChGEoGFpJMdRJjovN5lCewDRbA=; b=NmM6eDuiQVNgaHy0gIgCrc91HhVpHMouEdTKiqgv+a5pWy0YI+YYRUX3 exsY2W2AqGSlDQeWwQ8+nrgbiy59jDIurmHl2fAEK5WqW5o65LuXgDAn1 TzRP2e0fCfQbji5ggOEAcg/J/lFh8kTIkJKwYVKoFVMBr+L/Ud2PxUbFy /LhtBamY5pzV02f3HS90KDseUIdVUIIBL4KXZZ5+qVgCiLkygBFnNAd/J Znm6Kbf8Xmk54z9xykqJg33IXQez7jpkMS+IjuNsK1a457ZuxPXknVIw+ NbXgY1xp4PZ25RBhjdF5s7fxrLqaOugkj+BsELH2fFoJKmOUc01GGo0SX w==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="252724623" X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="252724623" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2022 08:36:06 -0800 X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="509317892" Received: from smile.fi.intel.com ([10.237.72.59]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2022 08:36:03 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1nNdYo-008GPw-6W; Fri, 25 Feb 2022 18:35:14 +0200 Date: Fri, 25 Feb 2022 18:35:13 +0200 From: Andy Shevchenko To: Hans de Goede Cc: Mark Gross , Andy Shevchenko , Mika Westerberg , Linus Walleij , platform-driver-x86@vger.kernel.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH 4/5] platform/x86: x86-android-tablets: Workaround Lenovo Yoga Tablet 2 830/1050 poweroff hang Message-ID: References: <20220223133153.730337-1-hdegoede@redhat.com> <20220223133153.730337-5-hdegoede@redhat.com> <0568e484-4ab2-5641-53ae-29ff48e952e6@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0568e484-4ab2-5641-53ae-29ff48e952e6@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org On Thu, Feb 24, 2022 at 05:57:11PM +0100, Hans de Goede wrote: > Hi, > > On 2/23/22 15:58, Andy Shevchenko wrote: > > On Wed, Feb 23, 2022 at 02:31:52PM +0100, Hans de Goede wrote: > >> These tablets' DSDT does not set acpi_gbl_reduced_hardware, so > >> acpi_power_off gets used as pm_power_off handler. This causes "poweroff" > >> on these tablets to hang hard. Requiring pressing the powerbutton for > >> 30 seconds *twice* followed by a normal 3 second press to recover. > >> > >> Avoid this by overriding the global pm_power_off handler to do > >> an EFI poweroff instead. > > > > Oh, you eventually found the root cause (reduced HW bit)? > > I'm not sure, it is possible that not setting the reduced HW bit > is actually correct for this hw, but that does lead to using > acpi_power_off which seems broken on this system. > > I've updated the commit message while merging this to reflect > that using acpi_power_off is the problem, rather then not setting > the reduced HW bit. Understood. Thanks! > Also note that the issue of reboot being the same as poweroff once > the system has been rebooted at least once is still unresolved. -- With Best Regards, Andy Shevchenko