From: Hans de Goede <hdegoede@redhat.com>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
mgross@linux.intel.com
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: tools/power/x86/intel-speed-select: Fixes for regression
Date: Mon, 4 Jan 2021 12:57:19 +0100 [thread overview]
Message-ID: <a290b74e-4b04-7eb9-196e-381a45f0a2db@redhat.com> (raw)
In-Reply-To: <489cb4bb-28b5-e7c8-829e-3d58f047f514@redhat.com>
Hi,
On 1/4/21 12:56 PM, Hans de Goede wrote:
> Hi,
>
> On 12/21/20 8:18 AM, Srinivas Pandruvada wrote:
>> One side-effect of fixing the scaling frequency limits using the
>> commit eacc9c5a927e ("cpufreq: intel_pstate: Fix intel_pstate_get_hwp_max()
>> for turbo disabled") causes stale HWP_CAP.GUARANTEED to be used as max.
>> Without processing HWP interrupts, user space needs to be able to update
>> a new max while Intel SST is in use. This is not a problem as the
>> change of guaranteed is caused by user space action, so user space knows
>> that guarantee will change.
>>
>> This series causes user space to trigger scaling_max_freq update with
>> the new base_frequency.
>>
>>
>> Srinivas Pandruvada (2):
>> tools/power/x86/intel-speed-select: Set scaling_max_freq to
>> base_frequency
>> tools/power/x86/intel-speed-select: Set higher of cpuinfo_max_freq or
>> base_frequency
>
> Thank you for your patch-series, I've applied the series to my
> review-hans branch:
> https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
>
> Note it will show up in my review-hans branch once I've pushed my
> local branch there, which might take a while.
>
> Once I've run some tests on this branch the patches there will be
> added to the platform-drivers-x86/for-next branch and eventually
> will be included in the pdx86 pull-request to Linus for the next
> merge-window.
Note this is a templated reply, I will also cherry-pick these into the
fixes branch in this case.
Regards,
Hans
next prev parent reply other threads:[~2021-01-04 11:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 7:18 tools/power/x86/intel-speed-select: Fixes for regression Srinivas Pandruvada
2020-12-21 7:18 ` [PATCH 1/2] tools/power/x86/intel-speed-select: Set scaling_max_freq to base_frequency Srinivas Pandruvada
2020-12-21 7:18 ` [PATCH 2/2] tools/power/x86/intel-speed-select: Set higher of cpuinfo_max_freq or base_frequency Srinivas Pandruvada
2021-01-04 11:56 ` tools/power/x86/intel-speed-select: Fixes for regression Hans de Goede
2021-01-04 11:57 ` Hans de Goede [this message]
2021-01-04 12:01 ` Srinivas Pandruvada
2021-01-04 12:00 ` Srinivas Pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a290b74e-4b04-7eb9-196e-381a45f0a2db@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox