platform-driver-x86.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] platform/x86:intel/pmc: Update Arrow Lake telemetry GUID
@ 2025-08-14 19:51 Xi Pardee
  2025-08-18 15:40 ` Mark Pearson
  0 siblings, 1 reply; 4+ messages in thread
From: Xi Pardee @ 2025-08-14 19:51 UTC (permalink / raw)
  To: xi.pardee, irenic.rajneesh, david.e.box, hdegoede, ilpo.jarvinen,
	platform-driver-x86, linux-kernel, linux-pm, mpearson

Updated ARL_PMT_DMU_GUID value. Arrow Lake PMT DMU GUID has
been updated after it was released. This updates ensures that
the die c6 value is available in the debug filesystem.

Fixes: 83f168a1a437 ("platform/x86/intel/pmc: Add Arrow Lake S support to intel_pmc_core driver")
Signed-off-by: Xi Pardee <xi.pardee@linux.intel.com>
---
 drivers/platform/x86/intel/pmc/core.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel/pmc/core.h b/drivers/platform/x86/intel/pmc/core.h
index 4a94a4ee031e6..24139617eef61 100644
--- a/drivers/platform/x86/intel/pmc/core.h
+++ b/drivers/platform/x86/intel/pmc/core.h
@@ -282,7 +282,7 @@ enum ppfear_regs {
 /* Die C6 from PUNIT telemetry */
 #define MTL_PMT_DMU_DIE_C6_OFFSET		15
 #define MTL_PMT_DMU_GUID			0x1A067102
-#define ARL_PMT_DMU_GUID			0x1A06A000
+#define ARL_PMT_DMU_GUID			0x1A06A102
 
 #define LNL_PMC_MMIO_REG_LEN			0x2708
 #define LNL_PMC_LTR_OSSE			0x1B88
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/x86:intel/pmc: Update Arrow Lake telemetry GUID
  2025-08-14 19:51 [PATCH] platform/x86:intel/pmc: Update Arrow Lake telemetry GUID Xi Pardee
@ 2025-08-18 15:40 ` Mark Pearson
  2025-08-19 19:41   ` David Box
  0 siblings, 1 reply; 4+ messages in thread
From: Mark Pearson @ 2025-08-18 15:40 UTC (permalink / raw)
  To: Xi Pardee, irenic.rajneesh, david.e.box, Hans de Goede,
	Ilpo Järvinen, platform-driver-x86@vger.kernel.org,
	linux-kernel, linux-pm

Thanks Xi

On Thu, Aug 14, 2025, at 3:51 PM, Xi Pardee wrote:
> Updated ARL_PMT_DMU_GUID value. Arrow Lake PMT DMU GUID has
> been updated after it was released. This updates ensures that
> the die c6 value is available in the debug filesystem.
>
> Fixes: 83f168a1a437 ("platform/x86/intel/pmc: Add Arrow Lake S support 
> to intel_pmc_core driver")
> Signed-off-by: Xi Pardee <xi.pardee@linux.intel.com>
> ---
>  drivers/platform/x86/intel/pmc/core.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/pmc/core.h 
> b/drivers/platform/x86/intel/pmc/core.h
> index 4a94a4ee031e6..24139617eef61 100644
> --- a/drivers/platform/x86/intel/pmc/core.h
> +++ b/drivers/platform/x86/intel/pmc/core.h
> @@ -282,7 +282,7 @@ enum ppfear_regs {
>  /* Die C6 from PUNIT telemetry */
>  #define MTL_PMT_DMU_DIE_C6_OFFSET		15
>  #define MTL_PMT_DMU_GUID			0x1A067102
> -#define ARL_PMT_DMU_GUID			0x1A06A000
> +#define ARL_PMT_DMU_GUID			0x1A06A102
> 
>  #define LNL_PMC_MMIO_REG_LEN			0x2708
>  #define LNL_PMC_LTR_OSSE			0x1B88
> -- 
> 2.43.0

Tested this on my Lenovo P1 G8 and confirmed that it fixed the error message that was seen previously.

Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>

Mark

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/x86:intel/pmc: Update Arrow Lake telemetry GUID
  2025-08-18 15:40 ` Mark Pearson
@ 2025-08-19 19:41   ` David Box
  2025-08-20  6:21     ` Xi Pardee
  0 siblings, 1 reply; 4+ messages in thread
From: David Box @ 2025-08-19 19:41 UTC (permalink / raw)
  To: Mark Pearson
  Cc: Xi Pardee, irenic.rajneesh, Hans de Goede, Ilpo Järvinen,
	platform-driver-x86@vger.kernel.org, linux-kernel, linux-pm

Hi Xi,

On Mon, Aug 18, 2025 at 11:40:47AM -0400, Mark Pearson wrote:
> Thanks Xi
> 
> On Thu, Aug 14, 2025, at 3:51 PM, Xi Pardee wrote:
> > Updated ARL_PMT_DMU_GUID value. Arrow Lake PMT DMU GUID has
> > been updated after it was released. This updates ensures that
> > the die c6 value is available in the debug filesystem.
> >
> > Fixes: 83f168a1a437 ("platform/x86/intel/pmc: Add Arrow Lake S support 
> > to intel_pmc_core driver")
> > Signed-off-by: Xi Pardee <xi.pardee@linux.intel.com>
> > ---
> >  drivers/platform/x86/intel/pmc/core.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/platform/x86/intel/pmc/core.h 
> > b/drivers/platform/x86/intel/pmc/core.h
> > index 4a94a4ee031e6..24139617eef61 100644
> > --- a/drivers/platform/x86/intel/pmc/core.h
> > +++ b/drivers/platform/x86/intel/pmc/core.h
> > @@ -282,7 +282,7 @@ enum ppfear_regs {
> >  /* Die C6 from PUNIT telemetry */
> >  #define MTL_PMT_DMU_DIE_C6_OFFSET		15
> >  #define MTL_PMT_DMU_GUID			0x1A067102
> > -#define ARL_PMT_DMU_GUID			0x1A06A000
> > +#define ARL_PMT_DMU_GUID			0x1A06A102
> > 
> >  #define LNL_PMC_MMIO_REG_LEN			0x2708
> >  #define LNL_PMC_LTR_OSSE			0x1B88
> > -- 
> > 2.43.0
> 
> Tested this on my Lenovo P1 G8 and confirmed that it fixed the error message that was seen previously.
> 
> Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>

If you send another version, please tag with a link to the bugzilla,
https://bugzilla.kernel.org/show_bug.cgi?id=220421

Thanks

David

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] platform/x86:intel/pmc: Update Arrow Lake telemetry GUID
  2025-08-19 19:41   ` David Box
@ 2025-08-20  6:21     ` Xi Pardee
  0 siblings, 0 replies; 4+ messages in thread
From: Xi Pardee @ 2025-08-20  6:21 UTC (permalink / raw)
  To: David Box, Mark Pearson
  Cc: irenic.rajneesh, Hans de Goede, Ilpo Järvinen,
	platform-driver-x86@vger.kernel.org, linux-kernel, linux-pm

Hi David,

On 8/19/2025 12:41 PM, David Box wrote:
> Hi Xi,
>
> On Mon, Aug 18, 2025 at 11:40:47AM -0400, Mark Pearson wrote:
>> Thanks Xi
>>
>> On Thu, Aug 14, 2025, at 3:51 PM, Xi Pardee wrote:
>>> Updated ARL_PMT_DMU_GUID value. Arrow Lake PMT DMU GUID has
>>> been updated after it was released. This updates ensures that
>>> the die c6 value is available in the debug filesystem.
>>>
>>> Fixes: 83f168a1a437 ("platform/x86/intel/pmc: Add Arrow Lake S support
>>> to intel_pmc_core driver")
>>> Signed-off-by: Xi Pardee <xi.pardee@linux.intel.com>
>>> ---
>>>   drivers/platform/x86/intel/pmc/core.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/platform/x86/intel/pmc/core.h
>>> b/drivers/platform/x86/intel/pmc/core.h
>>> index 4a94a4ee031e6..24139617eef61 100644
>>> --- a/drivers/platform/x86/intel/pmc/core.h
>>> +++ b/drivers/platform/x86/intel/pmc/core.h
>>> @@ -282,7 +282,7 @@ enum ppfear_regs {
>>>   /* Die C6 from PUNIT telemetry */
>>>   #define MTL_PMT_DMU_DIE_C6_OFFSET		15
>>>   #define MTL_PMT_DMU_GUID			0x1A067102
>>> -#define ARL_PMT_DMU_GUID			0x1A06A000
>>> +#define ARL_PMT_DMU_GUID			0x1A06A102
>>>
>>>   #define LNL_PMC_MMIO_REG_LEN			0x2708
>>>   #define LNL_PMC_LTR_OSSE			0x1B88
>>> -- 
>>> 2.43.0
>> Tested this on my Lenovo P1 G8 and confirmed that it fixed the error message that was seen previously.
>>
>> Tested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> If you send another version, please tag with a link to the bugzilla,
> https://bugzilla.kernel.org/show_bug.cgi?id=220421
>
> Thanks
>
> David

Will add the bugzilla link in next version.

Thanks!

Xi


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-08-20  6:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-14 19:51 [PATCH] platform/x86:intel/pmc: Update Arrow Lake telemetry GUID Xi Pardee
2025-08-18 15:40 ` Mark Pearson
2025-08-19 19:41   ` David Box
2025-08-20  6:21     ` Xi Pardee

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).