From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Hans de Goede <hansg@kernel.org>,
Mario Limonciello <superm1@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<x86@kernel.org>, "H . Peter Anvin" <hpa@zytor.com>,
Jean Delvare <jdelvare@suse.com>,
Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
Hans de Goede <hdegoede@redhat.com>,
Mario Limonciello <mario.limonciello@amd.com>,
"open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)"
<linux-kernel@vger.kernel.org>,
"open list:I2C SUBSYSTEM HOST DRIVERS"
<linux-i2c@vger.kernel.org>,
"open list:AMD PMC DRIVER" <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH 1/2] Move FCH header to a location accessible by all archs
Date: Mon, 30 Jun 2025 13:46:35 +0300 (EEST) [thread overview]
Message-ID: <a6ccabd7-1436-ff73-398f-b92e546d3701@linux.intel.com> (raw)
In-Reply-To: <zkbd5qdfj3xrjh7l6sviqzsu6foyxpwsko47czrpet55kgqzfv@aw3igwk34irc>
On Wed, 25 Jun 2025, Andi Shyti wrote:
> Hi,
>
> On Thu, Jun 12, 2025 at 10:36:31AM +0200, Hans de Goede wrote:
> > Hi,
> >
> > On 10-Jun-25 10:58 PM, Mario Limonciello wrote:
> > > From: Mario Limonciello <mario.limonciello@amd.com>
> > >
> > > A new header fch.h was created to store registers used by different AMD
> > > drivers. This header was included by i2c-piix4 in
> > > commit 624b0d5696a8 ("i2c: piix4, x86/platform: Move the SB800 PIIX4 FCH
> > > definitions to <asm/amd/fch.h>"). To prevent compile failures on non-x86
> > > archs i2c-piix4 was set to only compile on x86 by commit 7e173eb82ae9717
> > > ("i2c: piix4: Make CONFIG_I2C_PIIX4 dependent on CONFIG_X86").
> > > This was not a good decision because loongarch and mips both actually
> > > support i2c-piix4 and set it enabled in the defconfig.
> > >
> > > Move the header to a location accessible by all architectures.
> > >
> > > Fixes: 624b0d5696a89 ("i2c: piix4, x86/platform: Move the SB800 PIIX4 FCH definitions to <asm/amd/fch.h>")
> > > Suggested-by: Hans de Goede <hansg@kernel.org>
> > > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> >
> > Thanks, patch looks good to me:
> >
> > Reviewed-by: Hans de Goede <hansg@kernel.org>
>
> I don't see this series in yet. I thought you were taking it,
> shall I take it through i2c?
I'm sorry I seem to have missed this inquiry until now. I thought x86
would handle it this but apparently they haven't.
(I'm the primary person handling pdx86 patches, not Hans any more).
I can take this now.
--
i.
prev parent reply other threads:[~2025-06-30 10:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-10 20:58 [PATCH 1/2] Move FCH header to a location accessible by all archs Mario Limonciello
2025-06-10 20:58 ` [PATCH 2/2] i2c: Re-enable piix4 driver on non-x86 Mario Limonciello
2025-06-11 21:53 ` Andi Shyti
2025-06-12 8:36 ` Hans de Goede
2025-06-12 8:36 ` [PATCH 1/2] Move FCH header to a location accessible by all archs Hans de Goede
2025-06-25 21:59 ` Andi Shyti
2025-06-30 10:46 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6ccabd7-1436-ff73-398f-b92e546d3701@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andi.shyti@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hansg@kernel.org \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=superm1@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox