From: Gregory Price <gourry@gourry.net>
To: Suma Hegde <suma.hegde@amd.com>
Cc: platform-driver-x86@vger.kernel.org,
ilpo.jarvinen@linux.intel.com, hdegoede@redhat.com,
Naveen Krishna Chatradhi <naveenkrishna.chatradhi@amd.com>
Subject: [BUG?] platform/x86/amd/hsmp: Create separate ACPI, plat and common drivers
Date: Fri, 18 Apr 2025 19:01:26 -0400 [thread overview]
Message-ID: <aALZxvHWmphNL1wa@gourry-fedora-PF4VCD3F> (raw)
In-Reply-To: <20241021111428.2676884-8-suma.hegde@amd.com>
On Mon, Oct 21, 2024 at 11:14:25AM +0000, Suma Hegde wrote:
> diff --git a/drivers/platform/x86/amd/hsmp/acpi.c b/drivers/platform/x86/amd/hsmp/acpi.c
... snip ...
> +#define DRIVER_NAME "amd_hsmp"
... snip ...
> diff --git a/drivers/platform/x86/amd/hsmp/plat.c b/drivers/platform/x86/amd/hsmp/plat.c
> +#define DRIVER_NAME "amd_hsmp"
Hi,
From looking around this patch, the code seems to suggest that these
drivers should not be mutually exclusive, but we are seeing an error
when attempting to load them both - apparently because they both use the
same driver name.
Was this intended, or should the DRIVER_NAME="hsmp_acpi" for acpi.c?
~Gregory
---
diff --git a/drivers/platform/x86/amd/hsmp/acpi.c b/drivers/platform/x86/amd/hsmp/acpi.c
index e981d45e1c12..871724995897 100644
--- a/drivers/platform/x86/amd/hsmp/acpi.c
+++ b/drivers/platform/x86/amd/hsmp/acpi.c
@@ -26,7 +26,7 @@
#include "hsmp.h"
-#define DRIVER_NAME "amd_hsmp"
+#define DRIVER_NAME "hsmp_acpi"
#define DRIVER_VERSION "2.3"
#define ACPI_HSMP_DEVICE_HID "AMDI0097"
next prev parent reply other threads:[~2025-04-18 23:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-21 11:14 [v10 01/11] platform/x86/amd/hsmp: Create hsmp/ directory Suma Hegde
2024-10-21 11:14 ` [v10 02/11] platform/x86/amd/hsmp: Create wrapper function init_acpi() Suma Hegde
2024-10-21 11:14 ` [v10 03/11] platform/x86/amd/hsmp: Convert amd_hsmp_rdwr() to a function pointer Suma Hegde
2024-10-21 11:14 ` [v10 04/11] platform/x86/amd/hsmp: Move structure and macros to header file Suma Hegde
2024-10-21 11:14 ` [v10 05/11] platform/x86/amd/hsmp: Move platform device specific code to plat.c Suma Hegde
2024-10-21 11:14 ` [v10 06/11] platform/x86/amd/hsmp: Move ACPI code to acpi.c Suma Hegde
2024-10-21 11:14 ` [v10 07/11] platform/x86/amd/hsmp: Change generic plat_dev name to hsmp_pdev Suma Hegde
2024-10-21 11:14 ` [v10 08/11] platform/x86/amd/hsmp: Create separate ACPI, plat and common drivers Suma Hegde
2025-04-18 23:01 ` Gregory Price [this message]
2025-04-19 8:59 ` [BUG?] " Hans de Goede
2025-04-21 10:34 ` Suma Hegde
2025-04-21 15:40 ` Hans de Goede
2025-04-23 10:28 ` Suma Hegde
2024-10-21 11:14 ` [v10 09/11] platform/x86/amd/hsmp: Use name space while exporting module symbols Suma Hegde
2024-10-21 11:14 ` [v10 10/11] platform/x86/amd/hsmp: Use dev_groups in the driver structure Suma Hegde
2024-10-21 11:14 ` [v10 11/11] platform/x86/amd/hsmp: Make hsmp_pdev static instead of global Suma Hegde
2024-10-22 10:37 ` [v10 01/11] platform/x86/amd/hsmp: Create hsmp/ directory Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aALZxvHWmphNL1wa@gourry-fedora-PF4VCD3F \
--to=gourry@gourry.net \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=naveenkrishna.chatradhi@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=suma.hegde@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox