X86 platform drivers
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Pearson <mpearson-lenovo@squebb.ca>
Cc: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com,
	ikepanhc@gmail.com, W_Armin@gmx.de, linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	ibm-acpi-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/2] platform/x86: Move Lenovo files into lenovo subdir
Date: Thu, 8 May 2025 17:29:23 +0300	[thread overview]
Message-ID: <aBy_w42MapjiD6al@smile.fi.intel.com> (raw)
In-Reply-To: <20250507190456.3004367-1-mpearson-lenovo@squebb.ca>

On Wed, May 07, 2025 at 03:04:34PM -0400, Mark Pearson wrote:
> Move all Lenovo specific files into their own sub-directory as part
> of clean-up exercise.
> Longer term goal is to break-up thinkpad_acpi to improve maintainability
> and perhaps share more functionality with other non thinkpad Lenovo
> platforms.

...

> Some questions that I didn't want to put in the commit comment:
> 
>  - I didn't know if now was a good time to propose this change. I
>    realise it could cause headaches for anybody with patches being
>    worked on. Please let me know what makes it easiest for maintainers
>    and other developers. If there is a particular branch that would be
>    better to do this against also let me know.

For me Git handles renaming very well.

>  - Should I be updating the MAINTAINERS file? I'm still not sure what
>    the protocol there is. I'm very happy to help review anything in the
>    lenovo directory, but I didn't want to make assumptions.
>  - I have tested on multiple platforms but I don't have any ideapads I
>    can use.

-- 
With Best Regards,
Andy Shevchenko



      parent reply	other threads:[~2025-05-08 14:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-07 19:04 [PATCH 1/2] platform/x86: Move Lenovo files into lenovo subdir Mark Pearson
2025-05-07 19:04 ` [PATCH 2/2] platform/x86: export thinkpad_acpi handles Mark Pearson
2025-05-08 14:03   ` Ilpo Järvinen
2025-05-08 14:28     ` Mark Pearson
2025-05-08 14:32       ` Andy Shevchenko
2025-05-08 15:02         ` Mark Pearson
2025-05-08 14:31   ` Andy Shevchenko
2025-05-08 15:01     ` Mark Pearson
2025-05-08 14:01 ` [PATCH 1/2] platform/x86: Move Lenovo files into lenovo subdir Ilpo Järvinen
2025-05-08 14:23   ` Mark Pearson
2025-05-08 14:27     ` Ilpo Järvinen
2025-05-08 14:29       ` Mark Pearson
2025-05-08 14:29 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBy_w42MapjiD6al@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=W_Armin@gmx.de \
    --cc=hdegoede@redhat.com \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ikepanhc@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox