* [PATCH] platform/x86: portwell-ec: don't print superfluous errors
@ 2025-08-13 19:08 Wolfram Sang
2025-08-13 19:10 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2025-08-13 19:08 UTC (permalink / raw)
To: platform-driver-x86
Cc: Wolfram Sang, Yen-Chi Huang, Hans de Goede, Ilpo Järvinen
The watchdog core will handle error messages already.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/platform/x86/portwell-ec.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/platform/x86/portwell-ec.c b/drivers/platform/x86/portwell-ec.c
index 322f296e9315..b4b7b42fa83d 100644
--- a/drivers/platform/x86/portwell-ec.c
+++ b/drivers/platform/x86/portwell-ec.c
@@ -238,10 +238,8 @@ static int pwec_probe(struct platform_device *pdev)
ec_wdt_dev.parent = &pdev->dev;
ret = devm_watchdog_register_device(&pdev->dev, &ec_wdt_dev);
- if (ret < 0) {
- dev_err(&pdev->dev, "failed to register Portwell EC Watchdog\n");
+ if (ret < 0)
return ret;
- }
return 0;
}
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: portwell-ec: don't print superfluous errors
2025-08-13 19:08 [PATCH] platform/x86: portwell-ec: don't print superfluous errors Wolfram Sang
@ 2025-08-13 19:10 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2025-08-13 19:10 UTC (permalink / raw)
To: platform-driver-x86; +Cc: Yen-Chi Huang, Hans de Goede, Ilpo Järvinen
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
> ec_wdt_dev.parent = &pdev->dev;
> ret = devm_watchdog_register_device(&pdev->dev, &ec_wdt_dev);
> - if (ret < 0) {
> - dev_err(&pdev->dev, "failed to register Portwell EC Watchdog\n");
> + if (ret < 0)
> return ret;
> - }
>
> return 0;
Argh, I just saw, this can be simplified more. Sorry for the premature
patch!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-13 19:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-13 19:08 [PATCH] platform/x86: portwell-ec: don't print superfluous errors Wolfram Sang
2025-08-13 19:10 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).