Re: [PATCH v4 0/2] Fix Omen 16-wf1xxx thermal profile and add EC readback

[Krishna Chomal <krishna.chomal108@gmail.com>]

On Mon, Jan 12, 2026 at 05:34:35PM +0200, Ilpo Järvinen wrote:
>On Thu, 18 Dec 2025 18:13:01 +0530, Krishna Chomal wrote:
>
>> This series fixes incorrect thermal profile parameters sent for HP Omen
>> 16-wf1xxx and implements hardware readback support for Victus S thermal
>> profiles.
>>
>> The first patch refactors the DMI handling for Victus S boards. By
>> moving from simple string list to DMI system id table with driver_data,
>> we can now map each board to its correct thermal parameters.
>>
>> [...]
>
>
>Thank you for your contribution, it has been applied to my local
>review-ilpo-next branch. Note it will show up in the public
>platform-drivers-x86/review-ilpo-next branch only once I've pushed my
>local branch there, which might take a while.
>
>The list of commits applied:
>[1/2] platform/x86: hp-wmi: fix platform profile values for Omen 16-wf1xxx
>      commit: d8bf01424f9eb555bf13b802a8ddffbb49f221a7
>[2/2] platform/x86: hp-wmi: Add EC offsets to read Victus S thermal profile
>      commit: 2511dd4dbb76ef6914c9b45ccba2492da25d772d
>
>--
> i.
>

Hi Ilpo,

I want to inform you about a potential issue in patch 2/2. My implementation
assumed a strict correlation between WMI command types and EC layouts,
but I have discovered this isn't universal. Some boards (like 8E35, not
present in this driver right now) use Victus S WMI commands but retain
the older EC layout (thermal profile offset: 0x95). Directly using
offset 0x59 for victus_s devices would not work for boards like 8E35.

To fix this, I suggest updating platform_profile_victus_s_get_ec(), to
check both of these offsets for a valid thermal profile.

I can either:
1. Send a follow-up patch to implement this iterative check.
2. Send a v5 with this logic integrated, if you prefer to drop the
    current series from your review branch.

Please let me know which path you prefer.