X86 platform drivers
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <ukleinek@debian.org>
To: Paul Kerry <p.kerry@sheffield.ac.uk>,
	 Mario Limonciello <mario.limonciello@amd.com>
Cc: 1127612@bugs.debian.org, Jorge Lopez <jorge.lopez2@hp.com>,
	 platform-driver-x86@vger.kernel.org
Subject: Re: Bug#1127612: linux-image-6.12.69+deb13-amd64: hp_bioscfg mm/page_alloc.c:4802 warning
Date: Sat, 21 Feb 2026 16:26:28 +0100	[thread overview]
Message-ID: <aZnNu_AphE78MIoY@monoceros> (raw)
In-Reply-To: <4faeb5e7-e56e-429e-88fa-a1fefa4d1034@amd.com>

[-- Attachment #1: Type: text/plain, Size: 2193 bytes --]

Hello,

On Tue, Feb 17, 2026 at 07:53:17AM -0600, Mario Limonciello wrote:
> On 2/16/26 10:18 AM, Paul Kerry wrote:
> > 
> > Hi Uwe
> > 
> > Thanks for the reply and information.
> > 
> > You are correct: when I boot the HP Z2 Tower G9 into the older
> > 6.12.63+deb13-amd64 kernel, the hp_bioscfg module is not loaded which I
> > had not noticed, and running a "modprobe hp_bioscfg" on that older
> > 6.12.63+deb13-amd64 kernel does indeed generate the same dmesg warnings
> > as 6.12.69+deb13-amd64 does, which auto-loads the hp_bioscfg module.
> > 
> > I've not had any noticeable problems caused by this issue since
> > 6.12.69+deb13-amd64 came out.
> 
> Considering there appears to be a rather large number of attributes on this
> system, maybe we should be using a different memory allocation method?
> 
> Something like this:
> 
> diff --git a/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> b/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> index f346aad8e9d89..72bd6037300ab 100644
> --- a/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> +++ b/drivers/platform/x86/hp/hp-bioscfg/enum-attributes.c
> @@ -94,8 +94,11 @@ int hp_alloc_enumeration_data(void)
>         bioscfg_drv.enumeration_instances_count =
>                 hp_get_instance_count(HP_WMI_BIOS_ENUMERATION_GUID);
> 
> -       bioscfg_drv.enumeration_data =
> kcalloc(bioscfg_drv.enumeration_instances_count,
> - sizeof(*bioscfg_drv.enumeration_data), GFP_KERNEL);
> +       if (!bioscfg_drv.enumeration_instances_count)
> +               return -EINVAL;
> +
> +       bioscfg_drv.enumeration_data =
> kvcalloc(bioscfg_drv.enumeration_instances_count,
> + sizeof(*bioscfg_drv.enumeration_data), GFP_KERNEL);
>         if (!bioscfg_drv.enumeration_data) {
>                 bioscfg_drv.enumeration_instances_count = 0;
>                 return -ENOMEM;

The patch looks fine to me and now I wonder how to continue here. Would
a test by Paul help? Or are we sure enough the patch is fine?

@Paul: Could you test the patch? Are you able to create a kernel image
with that patch included yourself, or would a test package help you?

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2026-02-21 15:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <dafda4bd-87cb-4fbd-a811-66d629a10c70@sheffield.ac.uk>
2026-02-16 15:34 ` Bug#1127612: linux-image-6.12.69+deb13-amd64: hp_bioscfg mm/page_alloc.c:4802 warning Uwe Kleine-König
2026-02-16 16:18   ` Paul Kerry
2026-02-17 13:53     ` Mario Limonciello
2026-02-21 15:26       ` Uwe Kleine-König [this message]
2026-02-23  6:06         ` Mario Limonciello
     [not found]           ` <7599e019-5c25-4bce-8308-05d53699a2f5@sheffield.ac.uk>
2026-02-23 14:26             ` Paul Kerry
2026-02-23 14:28               ` Mario Limonciello
2026-02-23 16:39                 ` Mario Limonciello
2026-02-24 11:21                   ` Paul Kerry
2026-02-24 15:05                     ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aZnNu_AphE78MIoY@monoceros \
    --to=ukleinek@debian.org \
    --cc=1127612@bugs.debian.org \
    --cc=jorge.lopez2@hp.com \
    --cc=mario.limonciello@amd.com \
    --cc=p.kerry@sheffield.ac.uk \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox