From: Armin Wolf <W_Armin@gmx.de>
To: kemal <kmal@cock.li>, platform-driver-x86@vger.kernel.org
Subject: Re: toshiba_acpi: fn key started working inverse in satellite L50-B
Date: Mon, 1 Jul 2024 19:14:16 +0200 [thread overview]
Message-ID: <aa43984d-ded7-4edf-8d8d-00225ae39979@gmx.de> (raw)
In-Reply-To: <R4CYFS.TWB8QUU2SHWI1@cock.li>
Am 01.07.24 um 17:53 schrieb kemal:
> in my TOSHIBA SATELLITE L50-B, the fn key started working
> the inverse of how it should after upgrading to kernel 6.9.7
> fn+function key used to emit an actual function key press, now instead
> it emits a hotkey press and the key itself emits an actual function key
> press. there are some recent commits to toshiba_acpi, but i cant see how
> it could affect my hardware.
> what could be the reason i lost the old behavior?
Hi,
it seems that commit 23f1d8b47d12 ("platform/x86: toshiba_acpi: Add quirk for buttons on Z830")
botched up the DMI quirk handling.
The global quick flag is tested in toshiba_acpi_enable_hotkeys(), which is called by
toshiba_acpi_setup_keyboard() before the global quirk flag is properly initialized.
Can you compile kernel modules on your device? If yes, then i can send you a prototype version
of this driver which should fix this issue.
Thanks,
Armin Wolf
next prev parent reply other threads:[~2024-07-01 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 15:53 toshiba_acpi: fn key started working inverse in satellite L50-B kemal
2024-07-01 17:14 ` Armin Wolf [this message]
2024-07-01 19:09 ` Armin Wolf
2024-07-01 19:41 ` kemal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa43984d-ded7-4edf-8d8d-00225ae39979@gmx.de \
--to=w_armin@gmx.de \
--cc=kmal@cock.li \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox