Re: [PATCH 01/13] of: Add wrappers to match root node with OF device ID tables

[Krzysztof Kozlowski <krzk@kernel.org>]

On 06/11/2025 20:53, Frank Li wrote:
> On Thu, Nov 06, 2025 at 08:07:08PM +0100, Krzysztof Kozlowski wrote:
>> Several drivers duplicate same code for getting reference to the root
>> node, matching it against 'struct of_device_id' table and getting out
>> the match data from the table entry.
>>
>> There is a of_machine_compatible_match() wrapper but it takes array of
>> strings, which is not suitable for many drivers since they want the
>> driver data associated with each compatible.
>>
>> Add two wrappers, similar to existing of_device_get_match_data():
>> 1. of_machine_device_match() doing only matching against 'struct
>>    of_device_id' and returning bool.
>> 2. of_machine_get_match_data() doing the matching and returning
>>    associated driver data for found compatible.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> ---
>>
>> All further patches depend on this.
>> ---
> 
> ...
>>
>> +/**
>> + * of_machine_device_match - Test root of device tree against a of_device_id array
>> + * @matches:	NULL terminated array of of_device_id match structures to search in
>> + *
>> + * Returns true if the root node has any of the given compatible values in its
>> + * compatible property.
>> + */
>> +bool of_machine_device_match(const struct of_device_id *matches)
> 
> Will it be more useful if pass down path

Path is fixed, there is no point to pass it. If you claim otherwise,
please bring example what benefits would it bring, instead of just
asking nitpicking questions.

> 
> of_machine_device_match(const char* path, const struct of_device_id *matches)
> 
> caller just pass "\", or NULL point as root
> 
>> +{
>> +	struct device_node *root;
>> +	const struct of_device_id *match = NULL;
>> +
>> +	root = of_find_node_by_path("/");
> 
> Use clean up will simplify code
> 
> 	struct device_node *root = __free(device_node) = of_find_node_by_path("/");
Not much difference. Look at existing code first. This should not
introduce different style.

Best regards,
Krzysztof