Re: [PATCH v5 0/2] platform/x86: hp-wmi: Add Victus 15-fb0xxx fan control

[Krishna Chomal <krishna.chomal108@gmail.com>]

On Wed, May 20, 2026 at 07:37:46PM +0530, Radhey Kalra wrote:
>Hi,
>
>This is a smaller v5 split for the Victus 15-fb0xxx fan-control change.
>Patch 1 prepares the hp-wmi board data and hwmon fan-control selection
>so fan support can be described independently from Victus S thermal
>profiles. Patch 2 adds fan-control support for Victus 15-fb0xxx board
>8A3D.
>

I am sure I must be missing something but I don't see why this isn't
just a DMI table addition?

I understand that you want to refactor the structs to decouple fan control
from platform profile so that you can just use fan control feature and
ignore platform profile, but I don't understand why that is done?

If I use victus_8a3d_board_params quirk on my device (8C78), it effectively
removes platform profile support, why is this choice made?

>Based on platform-drivers-x86/for-next commit:
>165e81354eefd5551358112773f24027aac59d5a
>
>Tested on a Victus by HP Gaming Laptop 15-fb0xxx, board 8A3D, BIOS
>F.22. With the series applied, pwm1 and pwm1_enable are exposed and
>the EC-layout warning is not emitted for 8A3D.
>
>Radhey Kalra (2):
>  platform/x86: hp-wmi: Prepare Victus fan control board data
>  platform/x86: hp-wmi: Add Victus 15-fb0xxx fan control
>
> drivers/platform/x86/hp/hp-wmi.c | 212 ++++++++++++++++++++++---------
> 1 file changed, 153 insertions(+), 59 deletions(-)
>
>---
>Changes in v5:
>- Reduce the series to two patches: one preparatory board-data/hwmon
>  patch and one focused 8A3D enablement patch.
>- Drop the active_thermal_profile_params global and dereference the
>  thermal-profile data through active_board_params.
>- Wrap the setup comment added in the preparatory patch to stay under
>  80 columns.
>
>Changes in v4:
>- Split v3 into two no-functional-changes-intended refactors, one
>  fan-table parsing fix, and one 8A3D support patch.
>- Rebase on platform-drivers-x86/for-next commit 165e81354eefd555.
>- Move revision notes to the cover letter.
>
>Changes in v3:
>- Rebase on platform-drivers-x86/for-next commit 165e81354eefd555.
>- Keep the v2 board-data approach and 8A3D fan-control-only handling.
>
>Changes in v2:
>- Use real name in Signed-off-by.
>- Replace the ad-hoc fan-control DMI table with board data in
>  .driver_data.
>- Keep 8A3D fan-control-only instead of enabling Victus S thermal
>  profiles.
>- Use the fixed fan-table parser path and derive gpu_delta from the
>  first non-zero GPU row.
>
>-- 
>2.54.0