From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Sean Rhodes <sean@starlabs.systems>
Cc: linux-kernel@vger.kernel.org,
"Corentin Chary" <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
"Denis Benato" <denis.benato@linux.dev>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Prasanth Ksr" <prasanth.ksr@dell.com>,
"Jorge Lopez" <jorge.lopez2@hp.com>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
"Joshua Grisham" <josh@joshuagrisham.com>,
platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com,
"Michael S. Tsirkin" <mst@redhat.com>,
"Chen-Yu Tsai" <wenst@chromium.org>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Brian Norris" <briannorris@chromium.org>,
"Julius Werner" <jwerner@chromium.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Titouan Ameline de Cadeville" <titouan.ameline@gmail.com>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
"Kees Cook" <kees@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
chrome-platform@lists.linux.dev, dri-devel@lists.freedesktop.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Eric Biggers" <ebiggers@kernel.org>,
"Luca Weiss" <luca.weiss@fairphone.com>,
"Michal Simek" <michal.simek@amd.com>,
"Sven Peter" <sven@kernel.org>
Subject: Re: [PATCH v13 RESEND 1/5] platform/x86: Sort firmware attributes class includes
Date: Wed, 26 Aug 2026 06:07:14 +0000 [thread overview]
Message-ID: <ao6CkvFgrZeo-s8J@google.com> (raw)
In-Reply-To: <b967ec0f8adb69417a3d81ee5546e4a238e29e11.1787584107.git.sean@starlabs.systems>
On Mon, Aug 24, 2026 at 04:08:58PM +0100, Sean Rhodes wrote:
> Move firmware_attributes_class.h into the main include block and sort the
> affected includes. This lets the header move replace each include in place.
...
> diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c
> index 495dc1e31d40..f3d8c5a85762 100644
> --- a/drivers/platform/x86/asus-armoury.c
> +++ b/drivers/platform/x86/asus-armoury.c
> @@ -20,6 +20,7 @@
> #include <linux/dmi.h>
> #include <linux/err.h>
> #include <linux/errno.h>
> +#include "firmware_attributes_class.h"
> #include <linux/fs.h>
> #include <linux/kernel.h>
> #include <linux/kmod.h>
I don't really follow why it is beneficial to make the
firmware_attributes_class.h replacement in-place. Moving relative includes
like "firmware_attributes_class.h" into the <linux/...> block creates an
awkward intermediate state. How about drop patch 1 and simply update the
includes directly in patch 2?
next prev parent reply other threads:[~2026-08-26 6:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-24 15:08 [PATCH v13 RESEND 0/5] coreboot CFR firmware attributes Sean Rhodes
2026-08-24 15:08 ` [PATCH v13 RESEND 1/5] platform/x86: Sort firmware attributes class includes Sean Rhodes
2026-08-26 6:07 ` Tzung-Bi Shih [this message]
2026-08-24 15:08 ` [PATCH v13 RESEND 2/5] firmware: Move firmware attributes class helper Sean Rhodes
2026-08-24 15:09 ` [PATCH v13 RESEND 3/5] firmware: Rename google firmware directory to coreboot Sean Rhodes
2026-08-26 6:07 ` Tzung-Bi Shih
2026-08-24 15:09 ` [PATCH v13 RESEND 4/5] firmware: coreboot: Add CFR firmware attributes driver Sean Rhodes
2026-08-24 15:09 ` [PATCH v13 RESEND 5/5] arm64: defconfig: Update coreboot firmware symbols Sean Rhodes
-- strict thread matches above, loose matches on Subject: below --
2026-08-17 21:54 [PATCH v13 RESEND 0/5] coreboot CFR firmware attributes Sean Rhodes
2026-08-17 21:54 ` [PATCH v13 RESEND 1/5] platform/x86: Sort firmware attributes class includes Sean Rhodes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ao6CkvFgrZeo-s8J@google.com \
--to=tzungbi@kernel.org \
--cc=Dell.Client.Kernel@dell.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=briannorris@chromium.org \
--cc=chenhuacai@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=corentin.chary@gmail.com \
--cc=dakr@kernel.org \
--cc=denis.benato@linux.dev \
--cc=derekjohn.clark@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiggers@kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=geert@linux-m68k.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=javierm@redhat.com \
--cc=jorge.lopez2@hp.com \
--cc=josh@joshuagrisham.com \
--cc=jwerner@chromium.org \
--cc=kees@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=luke@ljones.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michal.simek@amd.com \
--cc=mpearson-lenovo@squebb.ca \
--cc=mripard@kernel.org \
--cc=mst@redhat.com \
--cc=o-takashi@sakamocchi.jp \
--cc=platform-driver-x86@vger.kernel.org \
--cc=prasanth.ksr@dell.com \
--cc=sean@starlabs.systems \
--cc=simona@ffwll.ch \
--cc=sven@kernel.org \
--cc=titouan.ameline@gmail.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@baylibre.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox