Re: [PATCH] platform/x86: hp-wmi: Fix board_params typo for 8DD6 board

[Krishna Chomal <krishna.chomal108@gmail.com>]

On Fri, Aug 28, 2026 at 02:51:39AM +0300, Arda Doğu Ari wrote:
>When adding support for board 8DD6, &omen_v1_no_ec_thermal_params
>was passed as driver_data instead of &omen_v1_no_ec_board_params.

Hi,

When I added support for 8DD6 [1] &omen_v1_no_ec_thermal_params was
indeed the correct quirk. But because Radhey Kalra's board-specific
feature data patch [2] was accepted first, my patch probably lead to a
merge conflict that had to be resolved manually, which is why this is
subtle bug got introduced in the first place.

>Because active_board_params expects a pointer to struct
>hp_wmi_board_params, dereferencing active_board_params->thermal_profile
>results in a type confusion bug and invalid memory access. Update the entry
>to point to omen_v1_no_ec_board_params.

Thank you very much for observing and sending a patch for the same.

[1]: https://lore.kernel.org/platform-driver-x86/20260623141314.33947-1-krishna.chomal108@gmail.com
[2]: https://lore.kernel.org/platform-driver-x86/20260615091034.987029-1-radheykalra901@gmail.com

>Fixes: a7320d6eb9c42 ("platform/x86: hp-wmi: Add support for OMEN MAX 16-ak0xxx (8DD6)")
>Cc: stable@vger.kernel.org
>Signed-off-by: Arda Doğu Ari <arfeliousheres@gmail.com>
>---
> drivers/platform/x86/hp/hp-wmi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c
>index b2773fc1aca4..615b4cf6fc45 100644
>--- a/drivers/platform/x86/hp/hp-wmi.c
>+++ b/drivers/platform/x86/hp/hp-wmi.c
>@@ -337,7 +337,7 @@ static const struct dmi_system_id hp_wmi_feature_boards[] __initconst = {
> 	},
> 	{
> 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8DD6") },
>-		.driver_data = (void *)&omen_v1_no_ec_thermal_params,
>+		.driver_data = (void *)&omen_v1_no_ec_board_params,
> 	},
> 	{
> 		.matches = { DMI_MATCH(DMI_BOARD_NAME, "8E35") },
>-- 
>2.55.0
>